Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix randomHex #3085

Merged
merged 4 commits into from
Oct 8, 2019
Merged

Fix randomHex #3085

merged 4 commits into from
Oct 8, 2019

Conversation

cgewecke
Copy link
Collaborator

@cgewecke cgewecke commented Oct 1, 2019 •
edited
Loading

Fixes #1490 for the 1.x branch by back-porting #2794.

Adds a randomHex unit test.

@alcuadrado alcuadrado mentioned this pull request Oct 1, 2019
Closed
@coveralls
Copy link

coveralls commented Oct 1, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 83.033% when pulling e6c57cf on cgewecke:backport/2794 into 35b2e22 on ethereum:1.x.

@cgewecke cgewecke added the 1.x 1.0 related issues label Oct 1, 2019
@nivida nivida added the Bug Addressing a bug label Oct 8, 2019
@nivida nivida merged commit 2b09606 into web3:1.x Oct 8, 2019
@cgewecke cgewecke deleted the backport/2794 branch October 8, 2019 05:25
nachomazzara pushed a commit to nachomazzara/web3.js that referenced this pull request Jun 4, 2020
@cgewecke @nachomazzara
Fix randomHex (web3#3085)
22c7bcb 
* randomHex fixed

* Add utils.randomHex unit test
@PinkDiamond1 PinkDiamond1 mentioned this pull request Aug 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nivida nivida nivida approved these changes

Assignees
No one assigned
Labels
1.x 1.0 related issues Bug Addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cgewecke @coveralls @nivida