Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure the immutability of function signTransaction input parameter #3119

Merged
merged 5 commits into from
Oct 13, 2019
Merged

Ensure the immutability of function signTransaction input parameter #3119

merged 5 commits into from
Oct 13, 2019

Conversation

barakman
Copy link
Contributor

Fixes #2190

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.007%) to 83.061% when pulling 726d6ee on barakman:patch-1 into 5e8738e on ethereum:1.x.

@coveralls
Copy link

coveralls commented Oct 10, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.007%) to 83.061% when pulling 3712a40 on barakman:patch-1 into 7a51cdc on ethereum:1.x.

@barakman barakman mentioned this pull request Oct 10, 2019
Closed
@nivida nivida added 1.x 1.0 related issues Enhancement Includes improvements or optimizations labels Oct 11, 2019
nivida
nivida suggested changes Oct 11, 2019
View reviewed changes
packages/web3-eth-accounts/src/index.js Outdated Show resolved Hide resolved
@nivida nivida added the In Progress Currently being worked on label Oct 11, 2019
@nivida nivida removed the In Progress Currently being worked on label Oct 13, 2019
@nivida nivida merged commit 38cc933 into web3:1.x Oct 13, 2019
@cgewecke cgewecke mentioned this pull request Dec 19, 2019
Closed
nachomazzara pushed a commit to nachomazzara/web3.js that referenced this pull request Jun 4, 2020
@barakman @nachomazzara
Ensure the immutability of function signTransaction input parameter (…
44b6e81 
…web3#3119)

* Ensure the immutability of function `signTransaction` input parameter

* Replace `JSON.parse(JSON.stringify(tx))` with `_.clone(tx)`

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nivida nivida nivida approved these changes

Assignees
No one assigned
Labels
1.x 1.0 related issues Enhancement Includes improvements or optimizations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barakman @coveralls @nivida