Code

Provider related improvements#3190

Code

Merged

holgerd77 merged 184 commits into1.xweb3/web3.js:1.xfrom provider-related-improvementsweb3/web3.js:provider-related-improvementsCopy head branch name to clipboardApr 6, 2020

+1,592-447

Commits

Commits on Oct 24, 2019

• requestManager handling and add of 'data' listener improved

  nivida

  committed
  1a05194

Commits on Oct 30, 2019

• Merge branch '1.x' into issue/1648

  nivida

  authored
  4f856c8

• packageInit, setProvider and related listener issue fixed with adding of a setRequestManager method

  nivida

  committed
  9c028ad

Commits on Oct 31, 2019

• periodically occuring 'connection not open on send()' fixed

  nivida

  committed
  0a978d8

Commits on Nov 6, 2019

• Attach ws event listeners using EventTarget API

  Show description for 57be867
  

  gabmontes

  authored and

  cgewecke

  committed
  57be867

• Add once to the WS provider interface

  Show description for 7c8451c
  

  gabmontes

  authored and

  cgewecke

  committed
  7c8451c

• Merge logic for resubscription

  Show description for 53a7d36
  

  gabmontes

  authored and

  cgewecke

  committed
  53a7d36

• Clear subscription id before resubscribing

  Show description for 666f087
  

  gabmontes

  authored and

  cgewecke

  committed
  666f087

• Avoid reentry when removing subscriptions

  Show description for 9c366e4
  

  gabmontes

  authored and

  cgewecke

  committed
  9c366e4

• Broadcast provider error to subscribers

  Show description for f35fc88
  

  gabmontes

  authored and

  cgewecke

  committed
  f35fc88

• Add support for WebSocket reconnections

  Show description for 4af2f2b
  

  gabmontes

  authored and

  cgewecke

  committed
  4af2f2b

• Try to reconnect on timeout too

  Show description for fbba26e
  

  gabmontes

  authored and

  cgewecke

  committed
  fbba26e

• Remove WS provider once listener on next tick

  

  gabmontes

  authored and

  cgewecke

  committed
  5f5c2b8

• Ensure resubscription is done on silent reconnects

  Show description for 6305262
  

  gabmontes

  authored and

  cgewecke

  committed
  6305262

• Fix indentation

  

  gabmontes

  authored and

  cgewecke

  committed
  ed96084

• Add subscribe tests / failing reconnection test

  cgewecke

  committed
  d31f7e2

• dynamic parameter detection is required

  nivida

  committed
  6b639e5

• already out-commented but not removed line removed in Registry.js

  nivida

  committed
  4e4d341

• Merge branch '1.x' into issue/1648

  nivida

  committed
  d624492

Commits on Nov 7, 2019

• Update packages/web3-providers-ws/src/index.js

  Show description for 8715096
  

  nivida

  and

  cgewecke

  authored
  8715096

• subscriptions are now hold in a Map in the RequestManager, and resubscribing after the connection got lost will now get triggered from the RequestManager instead of the subscriptions

  nivida

  committed
  3cc23f5

Commits on Nov 8, 2019

• Merge branch 'issue/1648' into provider-related-improvements

  nivida

  committed
  b0c22c3

• Merge branch 'issue/3092' into provider-related-improvements

  nivida

  committed
  62fc1b5

• Merge branch 'resubscribing-improved' into provider-related-improvements

  nivida

  committed
  3c77b99

• subscriptions handling updated in RequestManager

  nivida

  committed
  d2de9fd

• websocketprovider.once() updated

  nivida

  committed
  5c4b2da

• missing _this added

  nivida

  committed
  a62c543

• websocketprovider.send() does use the internal once() method now

  nivida

  committed
  4230f78

• no longer requried _reconnectIntervalId property removed in subscription.js and funcDoc added to websocketprovider.send()

  nivida

  committed
  155adc5

• requestQueue added to WebsocketProvider

  nivida

  committed
  f37a305

• explicit delete will now be used on connect to remove the request items instead of clearing it after. Who knows the connection could got interuppted 1ms after the connect event got emitted

  nivida

  committed
  68a5a33

• close and connect handler for requestQueue extended with stoping of re-sending or rejecting of the requests if the event connect or close got emitted

  nivida

  committed
  e5eacfb

• missing removeListener added to close requestQueue handler

  nivida

  committed
  b223a20

• removeListener moved to bottom of both requestQueue handlers and error message updated

  nivida

  committed
  e991785

• websocket-reconnector removed and reconnecting as first draft implemented

  nivida

  committed
  7b6c48b

• no longer required private methods removed

  nivida

  committed
  08d83b0

• missing funcDocs added in WebsocketProvider

  nivida

  committed
  0b8bedb

• missing object properties added to WebsocketProvider and eventemitter3 added to dependencies of the web3-providers-ws package

  nivida

  committed
  e7c41be

• websocketprovider.onMessage() updated for normal requests

  nivida

  committed
  de090b4

• websocketprovider.onMessage() updated for subscriptions

  nivida

  committed
  44688ef

• not required else and var remove in websocketprovider.onMessage() and position moved of emit(event) in some provider listeners

  nivida

  committed
  909b6c3

• maxReconnectAttempts options added to WebsocketProvider

  nivida

  committed
  1c9f306

• websocketprovider.reconnect() reconnect attempts condition updated

  nivida

  committed
  091851a

• maxReconnectAttempts error handling updated

  nivida

  committed
  e3be52f

• reconnecting property will now get set to false if the maximum of attempts is reached and parseURL helper moved out to helper file because of ethical reasons

  nivida

  committed
  4161ec5

• WS check removed because WS does exists in any case

  nivida

  committed
  e182974

• removeAllSocketListeners added to WebsocketProvider

  nivida

  committed
  21ae48f

• funcDoc updated and wrongly defined removeAllSocketListeners deleted

  nivida

  committed
  30da469

• addSocketListeners and removeAllSocketListeners with underscore as private defined

  nivida

  committed
  22c91d1

• addDefaultEvents function removed from WebsocketProvider

  nivida

  committed
  879fbca

• funcDoc updated for _addSocketListeners

  nivida

  committed
  d982f9f

• parse-url.js -> helpers.js renamed and btoa export added

  nivida

  committed
  1fbea04

• _removeAllSocketListeners -> _removeSocketListeners renamed in WebsocketProvider for consistency reasons with _addSocketListeners

  nivida

  committed
  99b5da9

• state object property 'reconnecting' removed and event 'reconnect' added

  nivida

  committed
  aaf4a30

• timeout removed in _parseResponse because the timeout in send will cover it and is also configurable

  nivida

  committed
  c75da8b

• removed web3-core-helpers package because it's not in usage anymore

  nivida

  committed
  1fdb56f

• not required var removed in reconnect and constructor typo fixed

  nivida

  committed
  f0c57a3

• underscore dependency removed because it's no longer in usage

  nivida

  committed
  56376f7

• isArray check fixed in Websocketprovider

  nivida

  committed
  16efbf2

• onError updated and send simplified in WebsocketProvider

  nivida

  committed
  dc88690

• error msg updated in onClose listener

  nivida

  committed
  d796635

• close listener added to RequestManager

  nivida

  committed
  7b3b122

• timeout handling moved back to _parseResponse to have it applied on subscriptions as well

  nivida

  committed
  9d2f65b

• timeout event name property added and applied

  nivida

  committed
  5931584

• scope issue fixed in WebsocketProvider

  nivida

  committed
  b344092

• ddefault value '1000' for the optional and newly added parameter code of the websocketprovider.disconnect() method. It will otherwise not close the connection if re-connecting is enabled

  nivida

  committed
  581cdbc

• timeout handling changed in WS provider to save a event listener in the RequestManager and provider event name properties are now used in the RequestManager

  nivida

  committed
  1f0689d

• recconectAttempts reset added, TODOs added, and order updated in the send methof of the WebsocketProvider object

  nivida

  committed
  a1e5762

• WebsocketProvider reconnecting options extended

  nivida

  committed
  0c1a32c

• WebsocketProvider timeout handling does now clean the requestQueue if not trying to reconnect

  nivida

  committed
  9ee548f

• reconnectOptions fixed in WebsocketProvider

  nivida

  committed
  52385b4

Commits on Nov 10, 2019

• 'connect' listener updated in RequestManager, func doc improved, and reconnect options extended/improved for the WebsocketProvider

  nivida

  committed
  4a30c79

• not required if removed in request-manager

  nivida

  committed
  297ffc9

• setting of reconnectOptions in WebsocketProvider updated

  nivida

  committed
  8e8c6b3

Commits on Nov 11, 2019

• inheritance and typo fixed in WebsocketProvider

  nivida

  committed
  2be288f

• removeSubscription fixed in RequestManager

  nivida

  committed
  11989cd

• test/contract.js updated because the RequestManager is now using a Map object instead of a plain data object

  nivida

  committed
  569f481

• version updated on severall places 1.2.1 -> 1.2.2 and package-lock if requied updated

  nivida

  committed
  9043ab3

• subscription error handling updated

  nivida

  committed
  bd2857a

• event handling and send method updated in WebsocketProvider

  nivida

  committed
  5559969

• gave the listeners a name in the request-manager to improve the DX during debuging

  nivida

  committed
  c552e98

• 'error is not defined' fixed in subscription.js

  nivida

  committed
  8f0a2cf

• reconnecting test updated and disconnect method simplified in WebsocketProvider. Test test is succeeding but it does trigger the reconnecting process again because I can't close the ganache server …

  Show description for eb27a23
  nivida

  committed
  eb27a23

Commits on Nov 18, 2019

• eth.subscribe.ganache test updated and the error handling of WebsocketProvider.send improved

  nivida

  committed
  3c0904d

• call of removeListener added to error and close listener in send method of the WebsocketProvider

  nivida

  committed
  1d05111

• test case added to eth.subscribe.ganache and error handling in the close listener of the RequestManager for subscriptions improved

  nivida

  committed
  1e6efaa

• test case for the connected listener added to eth.subscribe.ganache.js

  nivida

  committed
  453c742

• RequestManager inheritance fixed for web3-shh package

  nivida

  committed
  318c345

• provider handling for contracts updated. This was required because of the new way the RequestManager does get inherited

  nivida

  committed
  6df7456

• clearSubscriptions fixed in web3-eth-contract

  nivida

  committed
  2958284

• error and close event handling improved in WebsocketProvider.send with using of a Map

  nivida

  committed
  2951da7

• WebsocketProvider.send simplified

  nivida

  committed
  c5b0471

• id handling and deletion of request item from queue updated in WebsocketProvider.send

  nivida

  committed
  5727104

• missing requestQueue.has condition added to WebsocketProvider.send

  nivida

  committed
  349076d

• error handling updated the errorQueue will now be used instead of using the requestQueue to listen for close or event errors during execution of the request. (fixes a bug where transactions could g…

  Show description for 84ec342
  nivida

  committed
  84ec342

• Map objects changed to Set objects for both queue in the WebsocketProvider

  nivida

  committed
  bf61074

• additional timeout wrapped in if because this case only happens if the provider is reconnecting because of a manual call or because the reconnecting option auto is set to true

  nivida

  committed
  9160389

• errorQueue renamed to responseQueue, send method simplified, and not finished request do now get handled if the provider does start to reconnect

  nivida

  committed
  5b405f4

Commits on Nov 19, 2019

• order of removing and adding of a request from the response or request queue changed

  nivida

  committed
  a82f899

Commits on Dec 2, 2019

• Merge branch '1.x' into provider-related-improvements

  nivida

  committed
  f90842e

Commits on Dec 3, 2019

• exit option added to mocha for now until we are able to kill the ganache process in a clean way

  nivida

  committed
  07565a4

• Merge branch '1.x' into provider-related-improvements

  nivida

  committed
  a27af13

• later added options added to README.md of the web3-providers-ws package

  nivida

  committed
  ebf9239

• not required waitMs function removed from test.utils

  nivida

  committed
  1456620

• type definitions for providers corrected and extended

  nivida

  committed
  ef63cf7

• code-style improved and ERR_CONNECTION_REFUSED case added in WS provider

  nivida

  committed
  d9b080f

Commits on Dec 4, 2019

• code-style changes reverted

  nivida

  committed
  127b06c

• Merge branch '1.x' into provider-related-improvements

  nivida

  authored
  f5a1217

• Method object removed from changeset

  nivida

  committed
  81474d9

• Merge branch 'provider-related-improvements' of github.com:ethereum/web3.js into provider-related-improvements

  nivida

  committed
  52e5c5c

Commits on Dec 16, 2019

• clean up of the requestQueue in the WebsocketProvider fixed on timeout

  nivida

  committed
  a46dbcd

Commits on Dec 17, 2019

• Add tests for core-subscriptions edge cases

  cgewecke

  committed
  0168764

• Remove console.log in test

  cgewecke

  committed
  6cf61ed

• Use done

  cgewecke

  committed
  4c6bab9

• Rewrite resubscribe test per review comment

  cgewecke

  committed
  21d854c

• Increase resubscribes timeout

  cgewecke

  committed
  1cb8b80

• Remove .only

  cgewecke

  committed
  7790a26

• Add resubscribe to existing subscription case

  cgewecke

  committed
  ac880f6

Commits on Dec 18, 2019

• provider types moved back to web3-core-helpers package to not break existing code and during moving the tests improved

  nivida

  committed
  fb1d422

• the response and request queue does now get cleaned up if WebsocketProvider.reset does get called from a consumer

  nivida

  committed
  80ea81c

Commits on Dec 19, 2019

• Run initially emitted errors in a zero-length timeout (plus tests)

  cgewecke

  committed
  d21d746

Commits on Jan 6, 2020

• Wrap more immediate errors in 0 length timeouts

  cgewecke

  committed
  9038a7a

Commits on Jan 7, 2020

• Merge pull request #3276 from ethereum/pri/more-ganache-tests

  Show description for 5b51b2d
  nivida

  authored
  5b51b2d

Commits on Jan 8, 2020

• EventEmitter inheritance in WebsocketProvider improved

  nivida

  committed
  ebc2e32

• WebsocketProviderOptions interface updated, code style improved in eth.subscribe.ganache.js and websocket.reconnect.ganache test added

  nivida

  committed
  ec72aa9

Commits on Jan 9, 2020

• two manually reconnect cases added to websocket.reconnect.ganache test

  nivida

  committed
  1f8e75d

• Merge branch '1.x' into provider-related-improvements

  nivida

  committed
  3048f50

• error listener removed in WSProvider because the close listener does get triggered anyways, error handling immproved in WebsocketProvider and RequestManager

  nivida

  committed
  d7fb27f

• renaming of ConnectionTimeout to ConnectionTimeoutError reverted (breaking-change). Error types extended and required type test cases added

  nivida

  committed
  ab7e40b

• populating of MaxAttemptsReachedOnReconnectingError fixed and required error listener re-added to the RequestManager to populate the error also for subscriptions

  nivida

  committed
  84e1296

• emitting of error in close listener removed

  nivida

  committed
  0252714

Commits on Jan 10, 2020

• Add websocket / misc tests

  cgewecke

  committed
  b2e33de

• Show test failing when revert to earlier error

  cgewecke

  committed
  0b962da

• Add passing queued request test

  cgewecke

  committed
  b06d0fe

• Revert changes to contract.js, keeping two fixes

  cgewecke

  committed
  7975e64

Commits on Jan 11, 2020

• Comment out eth.setProvider in getEthContractInstance

  cgewecke

  committed
  5e1aec2

Commits on Jan 12, 2020

• Add failing tests for disconnect edge cases

  cgewecke

  committed
  8e9a408

• Make tests pass

  cgewecke

  committed
  a50d2e9

Commits on Jan 14, 2020

• Consolidate test files and rename websocket.ganache.js

  cgewecke

  committed
  4044687

• Add tests for mid-chunk parsing errors

  cgewecke

  committed
  7ad8d34

• Fix verdaccio by upgrading to 4.4.2

  cgewecke

  committed
  68ff063

Commits on Jan 15, 2020

• consistency of the code style in contract and websocket.ganache test increased

  nivida

  committed
  6428287

• Merge pull request #3299 from ethereum/pri/testing-gaps

  Show description for 7b6a389
  nivida

  authored
  7b6a389

• WebsocketProvider error handling compared to current and breaking changes removed. Known error objects extended with 'code' and 'reason' property.

  nivida

  committed
  57a50e8

• InvalidConnection error msg changed to the old one in the WebsocketProvider

  nivida

  committed
  d709ab2

• additional assertions added to websocket.ganache test to cover the 'code' and 'reason' property of the ConnectionError

  nivida

  committed
  3ca9b09

• Merge branch '1.x' into provider-related-improvements

  nivida

  authored
  f937631

• if condition fixed in RequestManager.clearSubscriptions

  nivida

  committed
  1b9c969

Commits on Jan 16, 2020

• Merge pull request #3314 from ethereum/pri/error-handling

  Show description for cd680eb
  nivida

  authored
  cd680eb

Commits on Jan 22, 2020

• Add failing tests for clean closed connections

  cgewecke

  committed
  044a4d5

Commits on Jan 23, 2020

• Check for error code in RequestManager close handler

  cgewecke

  committed
  b1a71b2

• Revert build, lock-file, TS re-org, & ENS changes

  cgewecke

  committed
  a84df3f

Commits on Jan 24, 2020

• Fix code comment

  cgewecke

  authored
  4b05a67

• as discussed in #3303 does this commit add a hint to the documenation if someone does passes the exact same provider instance again to the setProvider method of the current module

  nivida

  committed
  8bae2a9

Commits on Jan 27, 2020

• helpful note on wish removed

  nivida

  committed
  561c3eb

• Merge pull request #3303 from ethereum/pri/contract-js-clean

  Show description for 100dab7
  nivida

  authored
  100dab7

• no longer required setProvider removed in ENS.Registry

  nivida

  committed
  df21651

• Merge pull request #3330 from ethereum/pri/minimize-changeset

  Show description for e749c11
  nivida

  authored
  e749c11

• Use the web3-eth Contract constructor or the provider inheritance doesn't work as expected

  nivida

  committed
  5e3ad84

• Implement FakeIpcProvider.reset

  cgewecke

  committed
  060a71d

Commits on Jan 28, 2020

• Add ipc close error handling / add test conditions for case

  cgewecke

  committed
  191ae06

• Make sure event listeners are cleaned up in subscrip / WS ganache tests

  cgewecke

  committed
  35663ec

• Changes for RequestManager close handler per review

  cgewecke

  committed
  d8159e4

• Use once instead of removeAllListeners

  cgewecke

  committed
  3dd1d7b

• reset signature corrected in FakeIpcProvider

  nivida

  committed
  e303c61

• Merge pull request #3344 from ethereum/pri/fix-contract-js-test

  Show description for d05d608
  nivida

  authored
  d05d608

• Fix style issues

  cgewecke

  committed
  68d3716

• JSDoc

  cgewecke

  authored
  8749185

Commits on Jan 29, 2020

• missing requested changes from PR applied, funcDoc formatting improved, strange emitterInstance variable removed, and missing semicolons added to websocket.ganache test file

  nivida

  committed
  319710d

• not required msg var removed in errors.ConnectionCloseError

  nivida

  committed
  46ebb24

Commits on Jan 30, 2020

• Add subscript behavioral tests for disconnect & setProvider

  cgewecke

  committed
  9f4b28c

• Add delay between disconnect and server shutdown

  cgewecke

  committed
  1984430

• Remove unused emitter ref

  cgewecke

  authored
  e78bed7

• Update test/helpers/test.utils.js

  nivida

  authored
  bca6a58

• Merge pull request #3347 from ethereum/pri/isolation-tests

  Show description for 2223335
  nivida

  authored
  2223335

• Merge pull request #3329 from ethereum/pri/connection-close

  Show description for aff3a6c
  nivida

  authored
  aff3a6c

• increased code style consistency in web3-core

  nivida

  committed
  a805a27

Commits on Feb 20, 2020

• Update test/eth.subscribe.ganache.js

  Show description for 3ab0779
  

  nivida

  and

  cgewecke

  authored
  3ab0779

Commits on Mar 3, 2020

• Document WS clientConfig options in README and RTD

  cgewecke

  committed
  df8157e

Commits on Mar 20, 2020

• Merge pull request #3402 from ethereum/pri/document-ws-provider-options

  Show description for 288582f
  holgerd77

  authored
  288582f

Commits on Apr 2, 2020

• Merge 1.x into provider-related-improvements

  cgewecke

  committed
  51ee313

• Update web3-providers-ws package-lock for eventemitter3

  cgewecke

  committed
  dc3ed52

• Apply review formatting suggestions

  cgewecke

  authored
  f8b9b48

Commits on Apr 6, 2020

• Merge branch '1.x' into provider-related-improvements

  holgerd77

  authored
  2eb3ed1