Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm installation error for websocket and scrypt-shim #3211

Merged
merged 3 commits into from
Nov 15, 2019
Merged

Conversation

cgewecke
Copy link
Collaborator

Description

  • Use correctly named imports for @web3-js/websocket, @web3-js/scrypt-shim
  • Add dependency-check to build step in CI

Fixes #3210

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test with success and extended the tests if necessary.
  • I ran npm run build and tested the resulting file from dist folder in a browser.
  • I have tested my code on the live network.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.347% when pulling c516845 on issue/3210 into 79d0aff on 1.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web3@1.2.3 has broken dependencies
3 participants