Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check build in ci #3333

Closed
wants to merge 2 commits into from
Closed

Check build in ci #3333

wants to merge 2 commits into from

Conversation

cgewecke
Copy link
Collaborator

@cgewecke cgewecke commented Jan 23, 2020 •
edited
Loading

Description

Example for release 1.2.5 comment

After commenting out the browser job build step, the tests error with

Error: Cannot find module '../../packages/web3/dist/web3.min' from '/home/travis/build/ethereum/web3.js/test/helpers'

@cgewecke cgewecke mentioned this pull request Jan 23, 2020
Merged
10 tasks
@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.36% when pulling 0eb7693 on release/site-check into e919f81 on release/1.2.5.

@nivida
Copy link
Contributor

nivida commented Jan 24, 2020

Yes, this behaviour is because the packages/web3/dist/ folder is excluded with the .gitignore file and without executing the bundler build pipeline does it not exist.

@cgewecke cgewecke closed this Jan 24, 2020
@nivida nivida deleted the release/site-check branch January 27, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cgewecke @coveralls @nivida