Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release - 1.2.6 #3353

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,3 @@ packages/web3/dist/
lerna-debug.log
!./dist/web3.min.js
.nyc_output/
build/
contracts/
migrations/
truffle-config.js
test/config/ensAddresses.json
2 changes: 0 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ matrix:
env: TEST=e2e_ganache
- node_js: 10
env: TEST=e2e_mosaic
- node_js: 10
env: TEST=e2e_ens
- node_js: 10
env: TEST=e2e_browsers
addons:
Expand Down
9 changes: 2 additions & 7 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -125,19 +125,14 @@ Released with 1.0.0-beta.37 code base.
- fix: export bloom functions on the index.js
- Prefer receipt status to code availability on contract deployment (#3298)

## [Unreleased]

## [1.2.6]

### Added

- ENS module extended with the possibility to add a custom registry (#3301)
- Görli testnet ENS registry added to the known registries (#3338)

### Changed

- Ensure '0x' prefix is existing for Accounts.sign and Accounts.privateKeyToAccount (#3041)
- ENS registry addresses updated (#3353, https://medium.com/the-ethereum-name-service/ens-registry-migration-bug-fix-new-features-64379193a5a)

### Fixed

- Add missing subscription.on('connected') TS type definition (#3319)
## [Unreleased]
2 changes: 1 addition & 1 deletion dist/web3.min.js

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions docs/include_package-net.rst
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ Example

.. code-block:: javascript

web3.eth.net.isListening()
web3.eth.isListening()
.then(console.log);
> true

Expand Down Expand Up @@ -101,6 +101,6 @@ Example

.. code-block:: javascript

web3.eth.net.getPeerCount()
web3.eth.getPeerCount()
.then(console.log);
> 25
3 changes: 1 addition & 2 deletions docs/web3-eth-accounts.rst
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ privateKeyToAccount

.. code-block:: javascript

web3.eth.accounts.privateKeyToAccount(privateKey [, ignoreLength ]);
web3.eth.accounts.privateKeyToAccount(privateKey);

Creates an account object from a private key.

Expand All @@ -103,7 +103,6 @@ Parameters
----------

1. ``privateKey`` - ``String``: The private key to convert.
1. ``ignoreLength`` - ``Boolean``: If set to true does the ``privateKey`` length not get validated.

-------
Returns
Expand Down
29 changes: 0 additions & 29 deletions docs/web3-eth-ens.rst
Original file line number Diff line number Diff line change
Expand Up @@ -8,35 +8,6 @@ The ``web3.eth.ens`` functions let you interacting with ENS.

------------------------------------------------------------------------------

registryAddress
=====================

.. code-block:: javascript

web3.eth.ens.registryAddress;

The ``registryAddress`` property can be used to define a custom registry address when you are connected to an unknown chain.

.. note::
If no address is defined will it try to detect the registry on the chain you are currently connected with and on the call of ``setProvider`` in the Eth module will it keep the defined address and use it for the ENS module.

-------
Returns
-------

``String`` - The address of the custom registry.

-------
Example
-------

.. code-block:: javascript

web3.eth.ens.registryAddress;
> "0x314159265dD8dbb310642f98f50C066173C1259b"

------------------------------------------------------------------------------

registry
=====================

Expand Down
Loading