Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENS address in test corrected #3356

Merged
merged 1 commit into from
Feb 2, 2020
Merged

ENS address in test corrected #3356

merged 1 commit into from
Feb 2, 2020

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Feb 2, 2020 •
edited
Loading

Description

Applies the last changes from the security-patch release PR 1.2.6.

Type of change

  • Tests

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success and extended the tests if necessary.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@nivida nivida added the 1.x 1.0 related issues label Feb 2, 2020
@nivida nivida merged commit bcf219d into 1.x Feb 2, 2020
@nivida nivida deleted the quick-fix/ens-tests branch February 2, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.x 1.0 related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nivida