Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes intermittent CI build failures due to
dtslint
erroring out on installing TypeScript3.9
.As a workaround we install the latest typescript into each package and use the
--localTs
option. It's not ideal since we only test the types against one version, but it was the existing behavior prior to #3464 where I attempted to expand it. This PR also removes the now unnecessary// Minimum TypeScript Version
comments I put in to satisfy testing against prior versions in that PR.This PR also removes the devDep
definitelytyped-header-parser
sincedtslint
automatically includes it as a child dep and outdated pinned versions may cause future dtslint issues.Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases do cover all lines and branches of the added code.npm run build-all
and tested the resulting file/'s fromdist
folder in a browser.CHANGELOG.md
file in the root folder.