Emit "error" and "end" events on WebsocketProvider close #3486
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds "error" and "end" event emissions to the Provider "close" logic, restoring behavior that existed in the WebsocketProvider prior to 1.2.7.
At the moment if you've attached these listeners directly to the provider, they're not firing as expected when the client drops.
For background, this topic was raised in the #3190 review here. @nivida noted:
Believe the change in this PR addresses that concern. The subscription error callbacks are fired and deleted in the close handler before the final error event is emitted. Have added test logic in 4a3ef1e to verify that subscription error handlers are only run once when the connection drops.
Fixes #3485
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.CHANGELOG.md
file in the root folder.