Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix abi param encoding for tuple arrays #3541

Merged
merged 4 commits into from
May 27, 2020
Merged

Fix abi param encoding for tuple arrays #3541

merged 4 commits into from
May 27, 2020

Conversation

ryanio
Copy link
Collaborator

@ryanio ryanio commented May 25, 2020

Description

This PR fixes #3538 by handling param encoding of tuple arrays.

The first commit adds some failing tests (see ci failure), and the second commit should resolve them.

This was also a good opportunity to better organize some of the code by extracting formatParam into its own higher level method.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build-all and tested the resulting files from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@ryanio ryanio added Bug Addressing a bug 1.x 1.0 related issues labels May 25, 2020
@coveralls
Copy link

coveralls commented May 25, 2020

Coverage Status

Coverage increased (+0.02%) to 89.638% when pulling 77f003e on issue/3538 into d43fd6d on 1.x.

@ryanio ryanio added the Review Needed Maintainer(s) need to review label May 25, 2020
@cgewecke cgewecke self-requested a review May 26, 2020 14:35
Copy link
Collaborator

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🙂 LGTM.

@malaak-habashy
Copy link

@ryanio thank you

@ryanio ryanio merged commit c296b5e into 1.x May 27, 2020
@mpetrunic mpetrunic deleted the issue/3538 branch October 31, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Bug Addressing a bug Review Needed Maintainer(s) need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"coder.coders undefined" (Cannot read property 'forEach' of undefined)
4 participants