Add undefined callback check to websocket provider response queue #3574
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defensive programming per last sentence of paragraph 8 in #3573 (comment).
The now-doubled call to
.get(id)
seems like it might be a little inefficient. I'm not sure how that compares to calling.get(id)
once and assigning the result a temporary variable in terms of efficiency, but if someone wants to put some rigor into that selection it'd be helpful.I don't believe that any corresponding documentation changes are necessary.
A corresponding change in 2.x might be a good idea.
Description
Fixes #3573
Type of change
Checklist:
This is as complete as of initial PR submission as the original submitter will get it:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build-all
and tested the resulting files fromdist
folder in a browser.CHANGELOG.md
file in the root folder.