Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish the test site to Netlify #3575

Merged
merged 4 commits into from
Jun 9, 2020
Merged

Publish the test site to Netlify #3575

merged 4 commits into from
Jun 9, 2020

Conversation

ryanio
Copy link
Collaborator

@ryanio ryanio commented Jun 9, 2020

Description

This PR changes publishing the web3.js.min test site from Surge to Netlify to take advantage of PR Deploy Previews.

It looks like Netlify will automatically observe updates to 1.x and PRs to run new builds, but if it doesn't end up working well for us I can look into using their their github action netlify/actions/build.

Closes #3572

Type of change

  • CI

@ryanio ryanio added 1.x 1.0 related issues CI labels Jun 9, 2020
@coveralls
Copy link

coveralls commented Jun 9, 2020

Coverage Status

Coverage remained the same at 89.855% when pulling f07a418 on use-netlify into 076fd46 on 1.x.

@cgewecke cgewecke self-requested a review June 9, 2020 01:25
Copy link
Collaborator

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! This is great 🥇 🥇

@ryanio ryanio merged commit f52bf55 into 1.x Jun 9, 2020
@cgewecke cgewecke mentioned this pull request Jun 9, 2020
13 tasks
@evertonfraga evertonfraga deleted the use-netlify branch June 10, 2020 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use netlify for CDN test
3 participants