Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix param encoding for BN in arrays #3593

Merged
merged 3 commits into from
Jun 19, 2020
Merged

Fix param encoding for BN in arrays #3593

merged 3 commits into from
Jun 19, 2020

Conversation

cgewecke
Copy link
Collaborator

@cgewecke cgewecke commented Jun 19, 2020

Description

Moves logic that converts BN/Bignumber to string within formatParam (which recursively unpacks arrayified inputs)

Failing tests commit: 33bbf60

Fixes #3592

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build-all and tested the resulting files from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.

@coveralls
Copy link

coveralls commented Jun 19, 2020

Coverage Status

Coverage remained the same at 90.154% when pulling c114e31 on issue/3592 into db82053 on 1.x.

@cgewecke cgewecke added 1.x 1.0 related issues Bug Addressing a bug Review Needed Maintainer(s) need to review labels Jun 19, 2020
Copy link
Collaborator

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @cgewecke!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Bug Addressing a bug Review Needed Maintainer(s) need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect encoding of BigNumber for uint256[]
3 participants