-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #3685 - switch websocket package to remove node-gyp #3686
Conversation
@alcuadrado Speed increases look good 👍 |
The failing test seems to be a timeout when initializing a docker container that runs geth. Was this happening before? It seems unrelated to this pr's changes. |
This is unrelated. We're looking into it. Separate issue here #3687 |
I'm going to switch to a fork that is maintained by us. See #3685 for more details |
Closing in favour of #3704 |
* Supercedes #3686 * update changelog
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
See #3685 for full details.
This PR switches the websocket library to a temporary fork that removes the need to compile with node-gyp 🎊. The temporary fork is being maintained by Nomic Labs as a part of a larger effort to eradicate
node-gyp
from ethereum.Fixes #3685
Install stats (via github):
This PR: 106.935s
Current master: 146.577s
Difference: ~40s 👀
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.