Release/1.3.1 #3757

GregTheGreek · 2020-10-23T00:53:56Z

Description

This release candidate fixes some errors throughout the codebase, and patches some security vulnerabilities.

We're also extremely excited to finally announce that web3.js has support for the eth2 beaconchain API! It should be noted that the eth2 API will follow the web3.js versioning and start at v1.3.1 (upon formally release next week) and should be considered an alpha release. It also will not bloat the existing web3 object, and was not imported into it. In order to use the eth2 beaconchain API please install it separately using npm install --save web3-eth2-beaconchain!

Added

Add web3-eth2-core package (Add eth2 provider #3743)
Add web3-eth2-beaconchain package (Add eth2 provider #3743)

Changed

bump utils 0.10.0^ -> 0.12.0 (deps - bump util to get callbackify #3733)

Removed

Removed post-install script in packages/web3. Added documentation to root README (web3 postinstall script modifies files in another package #3717)

Fixed

Fix possible unhandled promise rejection when sending a transaction (UnhandledPromiseRejectionWarning when sending a transaction and the error event handler throws #3708)
Fixed decoding bytes and string parameters for logs emitted with solc 0.4.x (Upgrade abi coder to fix solc 0.4.x edge case #3724, getPastEvents works or not works depending on the event's location at the smart contract #3738)
Grammar changes to inputAddressFormatter error message
Fixed vulnerable dependencies

coveralls · 2020-10-23T01:10:01Z

Coverage increased (+2.4%) to 80.423% when pulling 1a850ae on release/1.3.1 into 27c9679 on 1.x.

spacesailor24 · 2020-10-23T22:21:37Z

Replicating the steps mentioned in previous releases

As part of the RC process, am doing some test installations in other projects and running their tests to see if everything.

installs properly
builds
tests pass

(This list will be actively edited)

Project	Desc	Status
oz-test-helpers	Test utils. Subset of their suite is web3 contracts	✔️
synthetix	~1000 units	✔️

oz-test-helpers fails with the following (not sure if this is related to the RC):

UPDATE Testing are passing as of 10/30/2020

259 passing (1m)
  4 failing

  1) Contract: expectEvent (web3 contracts) 
       default
         with events containing indexed parameters
           "before each" hook for "accepts events emitted by the directly called contract":
     Error: invalid number value (arg="indexedValue", coderType="uint256", value="2a")
      at Object.throwError (node_modules/web3-eth-abi/node_modules/ethers/utils/errors.js:68:17)
      at CoderNumber.encode (node_modules/web3-eth-abi/node_modules/ethers/utils/abi-coder.js:353:20)
      at /home/anon/tmp/openzeppelin-test-helpers/node_modules/web3-eth-abi/node_modules/ethers/utils/abi-coder.js:605:59
      at Array.forEach (<anonymous>)
      at pack (node_modules/web3-eth-abi/node_modules/ethers/utils/abi-coder.js:604:12)
      at CoderTuple.encode (node_modules/web3-eth-abi/node_modules/ethers/utils/abi-coder.js:764:16)
      at AbiCoder.encode (node_modules/web3-eth-abi/node_modules/ethers/utils/abi-coder.js:897:77)
      at ABICoder.encodeParameters (node_modules/web3-eth-abi/src/index.js:96:27)
      at /home/anon/tmp/openzeppelin-test-helpers/node_modules/web3-eth-contract/src/index.js:426:24
      at Array.map (<anonymous>)
      at Object._encodeMethodABI (node_modules/web3-eth-contract/src/index.js:425:12)
      at Object._processExecuteArguments (node_modules/web3-eth-contract/src/index.js:741:39)
      at Object._executeMethod (node_modules/web3-eth-contract/src/index.js:766:54)
      at Context.<anonymous> (test/src/expectEvent.web3.test.js:350:11)
      at processImmediate (internal/timers.js:456:21)

  2) Contract: expectEvent (web3 contracts) 
       default
         with events containing conflicting indexed parameters
           "before each" hook for "accepts events emitted by the directly called contract":
     Error: invalid number value (arg="indexedValue1", coderType="uint256", value="2a")
      at Object.throwError (node_modules/web3-eth-abi/node_modules/ethers/utils/errors.js:68:17)
      at CoderNumber.encode (node_modules/web3-eth-abi/node_modules/ethers/utils/abi-coder.js:353:20)
      at /home/anon/tmp/openzeppelin-test-helpers/node_modules/web3-eth-abi/node_modules/ethers/utils/abi-coder.js:605:59
      at Array.forEach (<anonymous>)
      at pack (node_modules/web3-eth-abi/node_modules/ethers/utils/abi-coder.js:604:12)
      at CoderTuple.encode (node_modules/web3-eth-abi/node_modules/ethers/utils/abi-coder.js:764:16)
      at AbiCoder.encode (node_modules/web3-eth-abi/node_modules/ethers/utils/abi-coder.js:897:77)
      at ABICoder.encodeParameters (node_modules/web3-eth-abi/src/index.js:96:27)
      at /home/anon/tmp/openzeppelin-test-helpers/node_modules/web3-eth-contract/src/index.js:426:24
      at Array.map (<anonymous>)
      at Object._encodeMethodABI (node_modules/web3-eth-contract/src/index.js:425:12)
      at Object._processExecuteArguments (node_modules/web3-eth-contract/src/index.js:741:39)
      at Object._executeMethod (node_modules/web3-eth-contract/src/index.js:766:54)
      at Context.<anonymous> (test/src/expectEvent.web3.test.js:373:11)
      at processImmediate (internal/timers.js:456:21)

  3) Contract: expectEvent (web3 contracts) 
       inTransaction
         with indexed event parameters
           "before each" hook for "accepts emitted events with correct indexed parameter and emitter object":
     Error: invalid number value (arg="indexedValue", coderType="uint256", value="2a")
      at Object.throwError (node_modules/web3-eth-abi/node_modules/ethers/utils/errors.js:68:17)
      at CoderNumber.encode (node_modules/web3-eth-abi/node_modules/ethers/utils/abi-coder.js:353:20)
      at /home/anon/tmp/openzeppelin-test-helpers/node_modules/web3-eth-abi/node_modules/ethers/utils/abi-coder.js:605:59
      at Array.forEach (<anonymous>)
      at pack (node_modules/web3-eth-abi/node_modules/ethers/utils/abi-coder.js:604:12)
      at CoderTuple.encode (node_modules/web3-eth-abi/node_modules/ethers/utils/abi-coder.js:764:16)
      at AbiCoder.encode (node_modules/web3-eth-abi/node_modules/ethers/utils/abi-coder.js:897:77)
      at ABICoder.encodeParameters (node_modules/web3-eth-abi/src/index.js:96:27)
      at /home/anon/tmp/openzeppelin-test-helpers/node_modules/web3-eth-contract/src/index.js:426:24
      at Array.map (<anonymous>)
      at Object._encodeMethodABI (node_modules/web3-eth-contract/src/index.js:425:12)
      at Object._processExecuteArguments (node_modules/web3-eth-contract/src/index.js:741:39)
      at Object._executeMethod (node_modules/web3-eth-contract/src/index.js:766:54)
      at Context.<anonymous> (test/src/expectEvent.web3.test.js:503:11)
      at processImmediate (internal/timers.js:456:21)

  4) Contract: expectEvent (web3 contracts) 
       inTransaction
         with conflicting indexed event parameters
           "before each" hook for "throws if the event from other contract is passed":
     Error: invalid number value (arg="indexedValue1", coderType="uint256", value="2a")
      at Object.throwError (node_modules/web3-eth-abi/node_modules/ethers/utils/errors.js:68:17)
      at CoderNumber.encode (node_modules/web3-eth-abi/node_modules/ethers/utils/abi-coder.js:353:20)
      at /home/anon/tmp/openzeppelin-test-helpers/node_modules/web3-eth-abi/node_modules/ethers/utils/abi-coder.js:605:59
      at Array.forEach (<anonymous>)
      at pack (node_modules/web3-eth-abi/node_modules/ethers/utils/abi-coder.js:604:12)
      at CoderTuple.encode (node_modules/web3-eth-abi/node_modules/ethers/utils/abi-coder.js:764:16)
      at AbiCoder.encode (node_modules/web3-eth-abi/node_modules/ethers/utils/abi-coder.js:897:77)
      at ABICoder.encodeParameters (node_modules/web3-eth-abi/src/index.js:96:27)
      at /home/anon/tmp/openzeppelin-test-helpers/node_modules/web3-eth-contract/src/index.js:426:24
      at Array.map (<anonymous>)
      at Object._encodeMethodABI (node_modules/web3-eth-contract/src/index.js:425:12)
      at Object._processExecuteArguments (node_modules/web3-eth-contract/src/index.js:741:39)
      at Object._executeMethod (node_modules/web3-eth-contract/src/index.js:766:54)
      at Context.<anonymous> (test/src/expectEvent.web3.test.js:551:11)
      at processImmediate (internal/timers.js:456:21)

synthetix fails with the following (also not sure if this is related to the RC):

UPDATE Testing are passing as of 10/30/2020

2436 passing (21m)
  17 pending
  4 failing

  1) Contract: BinaryOptionMarketManager @gas-skip @ovm-skip
       when integrating with modern contracts
         Market tracking
           Adding, resolving, and expiring markets properly updates market lists:
     TypeError: Cannot assign to read only property '0' of object '[object Array]'
      at Array.sort (<anonymous>)
      at Context.<anonymous> (test/contracts/BinaryOptionMarketManager.js:1000:64)
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (internal/process/task_queues.js:97:5)

  2) Contract: EtherCollateralsUSD
       when integrating with modern contracts
         when collateral is deposited
           should revert if the loan does not exist:
     AssertionError: expected 'value out-of-bounds (argument="loanID", value=-1, code=INVALID_ARGUMENT, version=abi/5.0.0-beta.153)' to include 'revert'
      at Object.assertRevert [as revert] (test/utils/index.js:477:11)
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (internal/process/task_queues.js:97:5)

  3) Contract: EtherCollateralsUSD
       when integrating with modern contracts
         when collateral is withdrawn
           should revert if the loan does not exist:
     AssertionError: expected 'value out-of-bounds (argument="loanID", value=-1, code=INVALID_ARGUMENT, version=abi/5.0.0-beta.153)' to include 'revert'
      at Object.assertRevert [as revert] (test/utils/index.js:477:11)
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (internal/process/task_queues.js:97:5)

  4) Contract: SystemSettings
       when integrating with modern contracts
         setTargetThreshold()
           reverts when owner set the Target threshold to negative:
     AssertionError: expected 'value out-of-bounds (argument="_percent", value=-1, code=INVALID_ARGUMENT, version=abi/5.0.0-beta.153)' to include 'revert'
      at Object.assertRevert [as revert] (test/utils/index.js:477:11)
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (internal/process/task_queues.js:97:5)

spacesailor24 · 2020-10-24T00:33:57Z

~~oz-test-helpers and synthetix tests seem to fail using version 1.3.0 as well~~ Pass as of 10/30/2020

GregTheGreek · 2020-10-24T00:38:42Z

out-of-bounds doesn't look good is it related to #3744 or #3692 ?

0xferit · 2020-11-04T21:58:57Z

Waiting so badly for this fix because of #3724

GregTheGreek · 2020-11-05T09:31:48Z

@ferittuncer It will be cut this week, we ran into some odd erros but believe they've all been addressed.

koraykoska

Looks good to me. Let's include #3773 and merge this.

GregTheGreek · 2020-11-19T12:01:21Z

I've retagged this and created the new release. waiting for the CI

0xferit · 2020-11-22T20:06:19Z

spacesailor24 · 2020-11-23T19:49:07Z

synthetix tests are still passing, but oz-test-helpers are failing with (I don't think it's related to RC):

UPDATE oz-test-helpers passes using version 0.5.6, but any later version fails with the folllowing error

Error: Cannot find module 'web3-eth-contract'
Require stack:
- /home/anon/tmp/openzeppelin-test-helpers/node_modules/@openzeppelin/contract-loader/lib/index.js
- /home/anon/tmp/openzeppelin-test-helpers/test/src/expectEvent.web3.test.js
- /home/anon/tmp/openzeppelin-test-helpers/node_modules/mocha/lib/mocha.js
- /home/anon/tmp/openzeppelin-test-helpers/node_modules/mocha/index.js
- /home/anon/tmp/openzeppelin-test-helpers/node_modules/truffle/build/commands.bundled.js
- /home/anon/tmp/openzeppelin-test-helpers/node_modules/truffle/build/cli.bundled.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:980:15)
    at Function.resolve (internal/modules/cjs/helpers.js:83:19)
    at Web3Loader.get [as web3Contract] (/home/anon/tmp/openzeppelin-test-helpers/node_modules/@openzeppelin/contract-loader/src/index.ts:100:33)
    at Web3Loader.fromABI (/home/anon/tmp/openzeppelin-test-helpers/node_modules/@openzeppelin/contract-loader/src/index.ts:88:21)
    at Web3Loader.BaseLoader.fromArtifact (/home/anon/tmp/openzeppelin-test-helpers/node_modules/@openzeppelin/contract-loader/src/index.ts:78:17)
    at Object.<anonymous> (/home/anon/tmp/openzeppelin-test-helpers/test/src/expectEvent.web3.test.js:13:33)
    at Module._compile (internal/modules/cjs/loader.js:1156:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1176:10)
    at Module.load (internal/modules/cjs/loader.js:1000:32)
    at Function.Module._load (internal/modules/cjs/loader.js:899:14)
    at Module.require (internal/modules/cjs/loader.js:1042:19)
    at require (internal/modules/cjs/helpers.js:77:18)
    at /home/anon/tmp/openzeppelin-test-helpers/node_modules/mocha/lib/mocha.js:390:36
    at Array.forEach (<anonymous>)
    at Mocha.loadFiles (/home/anon/tmp/openzeppelin-test-helpers/node_modules/mocha/lib/mocha.js:387:14)
    at Mocha.run (/home/anon/tmp/openzeppelin-test-helpers/node_modules/mocha/lib/mocha.js:961:10)
    at /home/anon/tmp/openzeppelin-test-helpers/node_modules/truffle/build/webpack:/packages/core/lib/test.js:170:1
    at new Promise (<anonymous>)
    at Object.run (/home/anon/tmp/openzeppelin-test-helpers/node_modules/truffle/build/webpack:/packages/core/lib/test.js:169:1)
Truffle v5.1.46 (core: 5.1.46)
Node v12.16.2

koraykoska

Looks good to me. What about changing the names of the taken package names?

EDIT: Why is coveralls failing?

GregTheGreek · 2020-11-26T10:13:22Z

@koraykoska nooo idea. I'm looking into it, didn't fail on any other pr so im finding it very odd.

re package nams: I'm in a dispute with npm so will probably put this on ice until then..

frankiebee

seems to have failed coveralls and dropped test coverage bellow %80
but this pr dosent look to have changed anything other then version so looks good 🤙

spacesailor24 · 2020-12-03T20:11:11Z

UPDATE 12/11/2020: Looks like adding a timeout of 20 seconds corrected this. Previously the test was using version 82.0 of Firefox and is now using the latest version, 83.0. @cgewecke found that encrypt seems to take a while in the new version of Firefox

Failing test:

✗ encrypt then decrypt wallet
	Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

Passes locally though:

✓ encrypt then decrypt wallet

  window.Web3 is defined
    ✓ loads

Firefox 78.0 (Ubuntu 0.0.0): Executed 87 of 87 SUCCESS (17.739 secs / 15.406 secs)
TOTAL: 87 SUCCESS

frankiebee

🎉

CLAassistant · 2021-01-07T09:48:01Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ spacesailor24
✅ GregTheGreek
❌ frankiebee
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

coveralls · 2021-01-07T20:51:10Z

Pull Request Test Coverage Report for Build 472514465

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 76.417%

Totals
Change from base Build 467243265:	0.0%
Covered Lines:	3159
Relevant Lines:	3928

💛 - Coveralls

GregTheGreek added 2 commits October 22, 2020 20:45

update changelog

2d28fac

release v1.3.1-rc.0

cdb7dd5

spacesailor24 mentioned this pull request Nov 3, 2020

getPastEvents works or not works depending on the event's location at the smart contract #3738

Closed

koraykoska self-requested a review November 9, 2020 09:18

koraykoska reviewed Nov 9, 2020

View reviewed changes

spacesailor24 mentioned this pull request Nov 11, 2020

Error on getPastEvents for solidity@0.4.x #3680

Closed

miranda76 previously approved these changes Nov 16, 2020

View reviewed changes

GregTheGreek added 2 commits November 19, 2020 06:43

Merge branch '1.x' into release/1.3.1

1d13e73

v1.3.1-rc.1

9018a97

GregTheGreek dismissed stale reviews from miranda76 and ghost via 9018a97 November 19, 2020 11:54

GregTheGreek marked this pull request as ready for review November 19, 2020 12:12

spacesailor24 requested review from spacesailor24, frankiebee and koraykoska November 24, 2020 17:32

spacesailor24 previously approved these changes Nov 24, 2020

View reviewed changes

koraykoska previously approved these changes Nov 26, 2020

View reviewed changes

frankiebee previously approved these changes Dec 1, 2020

View reviewed changes

Solve merge conflicts

518fd04

spacesailor24 dismissed frankiebee’s stale review via 518fd04 December 3, 2020 17:34

spacesailor24 dismissed stale reviews from koraykoska and themself via 518fd04 December 3, 2020 17:34

spacesailor24 requested review from spacesailor24, koraykoska and frankiebee December 3, 2020 17:35

spacesailor24 approved these changes Dec 3, 2020

View reviewed changes

frankiebee mentioned this pull request Dec 11, 2020

increase timeouts #3814

Merged

Merge branch '1.x' into release/1.3.1

70dafcb

frankiebee previously approved these changes Dec 12, 2020

View reviewed changes

GregTheGreek requested a review from spacesailor24 December 12, 2020 21:40

spacesailor24 previously approved these changes Dec 13, 2020

View reviewed changes

v1.3.1

1a850ae

GregTheGreek dismissed stale reviews from spacesailor24 and frankiebee via 1a850ae December 17, 2020 22:22

fix conflicts

c70d98b

spacesailor24 approved these changes Jan 7, 2021

View reviewed changes

GregTheGreek closed this Jan 8, 2021

GregTheGreek reopened this Jan 8, 2021

spacesailor24 mentioned this pull request Jan 18, 2021

Release/1.3.1 fix #3860

Merged

spacesailor24 closed this Jan 18, 2021

spacesailor24 deleted the release/1.3.1 branch January 18, 2021 20:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release/1.3.1 #3757

Release/1.3.1 #3757

GregTheGreek commented Oct 23, 2020

coveralls commented Oct 23, 2020 •

edited

Loading

spacesailor24 commented Oct 23, 2020 •

edited

Loading

spacesailor24 commented Oct 24, 2020 •

edited

Loading

GregTheGreek commented Oct 24, 2020

0xferit commented Nov 4, 2020 •

edited

Loading

GregTheGreek commented Nov 5, 2020

koraykoska left a comment

GregTheGreek commented Nov 19, 2020

0xferit commented Nov 22, 2020 •

edited

Loading

spacesailor24 commented Nov 23, 2020 •

edited

Loading

koraykoska left a comment •

edited

Loading

GregTheGreek commented Nov 26, 2020

frankiebee left a comment

spacesailor24 commented Dec 3, 2020 •

edited

Loading

frankiebee left a comment

CLAassistant commented Jan 7, 2021 •

edited

Loading

coveralls commented Jan 7, 2021 •

edited

Loading

Release/1.3.1 #3757

Release/1.3.1 #3757

Conversation

GregTheGreek commented Oct 23, 2020

Description

Added

Changed

Removed

Fixed

coveralls commented Oct 23, 2020 • edited Loading

spacesailor24 commented Oct 23, 2020 • edited Loading

spacesailor24 commented Oct 24, 2020 • edited Loading

GregTheGreek commented Oct 24, 2020

0xferit commented Nov 4, 2020 • edited Loading

GregTheGreek commented Nov 5, 2020

koraykoska left a comment

Choose a reason for hiding this comment

GregTheGreek commented Nov 19, 2020

0xferit commented Nov 22, 2020 • edited Loading

spacesailor24 commented Nov 23, 2020 • edited Loading

koraykoska left a comment • edited Loading

Choose a reason for hiding this comment

GregTheGreek commented Nov 26, 2020

frankiebee left a comment

Choose a reason for hiding this comment

spacesailor24 commented Dec 3, 2020 • edited Loading

frankiebee left a comment

Choose a reason for hiding this comment

CLAassistant commented Jan 7, 2021 • edited Loading

coveralls commented Jan 7, 2021 • edited Loading

Pull Request Test Coverage Report for Build 472514465

💛 - Coveralls

coveralls commented Oct 23, 2020 •

edited

Loading

spacesailor24 commented Oct 23, 2020 •

edited

Loading

spacesailor24 commented Oct 24, 2020 •

edited

Loading

0xferit commented Nov 4, 2020 •

edited

Loading

0xferit commented Nov 22, 2020 •

edited

Loading

spacesailor24 commented Nov 23, 2020 •

edited

Loading

koraykoska left a comment •

edited

Loading

spacesailor24 commented Dec 3, 2020 •

edited

Loading

CLAassistant commented Jan 7, 2021 •

edited

Loading

coveralls commented Jan 7, 2021 •

edited

Loading