Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'tsc' command in scripts & lerna run to 'compile' #3910

Closed
wants to merge 6 commits into from
Closed

Change 'tsc' command in scripts & lerna run to 'compile' #3910

wants to merge 6 commits into from

Conversation

slhodak
Copy link

@slhodak slhodak commented Feb 13, 2021

Description

Updates the tsc scripts in all packages to compile, and changes the usage in the main package.json from lerna run tsc to lerna run compile.

This is my first contribution to OSS, so please let me know if I need to cover everything in the checklist below. If so, for loading web3.min.js in a browser, is there a recommended client test application I can use?

Fixes #3894

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build
  • and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@coveralls
Copy link

coveralls commented Feb 13, 2021

Pull Request Test Coverage Report for Build 662671247

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 385 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-2.5%) to 73.759%

Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 88.0%
packages/web3-core-helpers/src/formatters.js 24 79.42%
packages/web3-core-helpers/src/errors.js 31 4.41%
packages/web3-utils/src/soliditySha3.js 55 5.56%
packages/web3-utils/src/index.js 60 30.0%
packages/web3-utils/src/utils.js 84 13.24%
packages/web3-eth-accounts/src/index.js 130 31.65%
Totals Coverage Status
Change from base Build 659174718: -2.5%
Covered Lines: 3292
Relevant Lines: 4223

💛 - Coveralls

Copy link

@RyanKeys RyanKeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Satisfies #3894, and does not create any build errors.

RyanKeys
RyanKeys previously approved these changes Mar 4, 2021
@spacesailor24 spacesailor24 added Enhancement Includes improvements or optimizations P3 Low severity bugs Review Needed Maintainer(s) need to review labels Mar 9, 2021
@spacesailor24 spacesailor24 dismissed stale reviews from RyanKeys and ghost via a8560ab March 16, 2021 02:17
spacesailor24
spacesailor24 previously approved these changes Mar 16, 2021
@spacesailor24
Copy link
Contributor

Closing in favor of #3958, there was an update to how Infura links are provided to tests (#3943) and it seems to be causing an issue here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Includes improvements or optimizations P3 Low severity bugs Review Needed Maintainer(s) need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tsc npm command to compile
4 participants