-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change 'tsc' command in scripts & lerna run to 'compile' #3910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 662671247
💛 - Coveralls |
RyanKeys
approved these changes
Mar 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Satisfies #3894, and does not create any build errors.
RyanKeys
previously approved these changes
Mar 4, 2021
spacesailor24
added
Enhancement
Includes improvements or optimizations
P3
Low severity bugs
Review Needed
Maintainer(s) need to review
labels
Mar 9, 2021
spacesailor24
previously approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Enhancement
Includes improvements or optimizations
P3
Low severity bugs
Review Needed
Maintainer(s) need to review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the
tsc
scripts in all packages tocompile
, and changes the usage in the mainpackage.json
fromlerna run tsc
tolerna run compile
.This is my first contribution to OSS, so please let me know if I need to cover everything in the checklist below. If so, for loading web3.min.js in a browser, is there a recommended client test application I can use?
Fixes #3894
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
dist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.