-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrectly versioned bn.js type export (#4418) #4437
Conversation
* fix incorrectly versioned bn.js type export Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * WIP Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * WIP Signed-off-by: Matt Rice <matthewcrice32@gmail.com>
Your Render PR Server URL is https://web3-js-pr-4437.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c5f4ve1t9ds0rsumov40. |
Oh I think I'm wrong about including In this particular case, we want to provide users with the specific version of the types so that type mismatches don't occur |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the change log we have very minimal change.
@types/bn.js
as dev-dependency to additional packages (notably web3-utils)
But the files which are changed are 27, Is there a possibility to only include required changes in this PR. And if there is any other package update we can create specific PR for it.
The files changes are all updates to |
Took over the original PR to make some changes