Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added webpack 5 create-react-app instructions #4670

Merged
merged 3 commits into from
Jan 10, 2022

Conversation

luu-alex
Copy link
Contributor

@luu-alex luu-alex commented Jan 6, 2022

Closes: #4659 #4173

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@render
Copy link

render bot commented Jan 6, 2022

@luu-alex luu-alex linked an issue Jan 6, 2022 that may be closed by this pull request
@luu-alex luu-alex marked this pull request as ready for review January 7, 2022 15:44
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@luu-alex luu-alex requested a review from nazarhussain January 7, 2022 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web3 don't work with latest of React Webpack5 support for create-react-app
4 participants