update getTransactionReceipt return type #4872
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdevcs
requested review from
luu-alex,
avkos,
nazarhussain,
nikoulai and
spacesailor24
Pull Request Test Coverage Report for Build 2434375382
💛 - Coveralls |
|
Could you please update the doc here? |
nikoulai
approved these changes
Mar 22, 2022
avkos
approved these changes
Mar 22, 2022
nazarhussain
approved these changes
Mar 28, 2022
MitrichDot
approved these changes
Apr 16, 2022
jdevcs
reviewed
Apr 27, 2022
| @@ -213,7 +213,7 @@ export interface TransactionReceipt { | |||
| contractAddress?: string; | |||
| cumulativeGasUsed: number; | |||
| gasUsed: number; | |||
| effectiveGasPrice: number; | |||
| effectiveGasPrice: string; | |||
There was a problem hiding this comment.
This will be breaking change in 1.x
MitrichDot
approved these changes
May 7, 2022
|
This issue is fixed in #5157 without introducing breaking change, so closing this PR. #5157 (review) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the type of
effectiveGasPricenumber to string in the object returned by thegetTransactionReceiptfunction due to a number overflow issue.Fixes #4819
Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.