Fix confirmation check after transaction getting stuck in a loop in some situations #4876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug that allows for a confirmation check to never end in some situations, such as when using .once('subscribe') and some other situations
Darkhogg
changed the title
jdevcs
requested review from
jdevcs,
nazarhussain,
spacesailor24 and
avkos
and removed request for
nazarhussain
Pull Request Test Coverage Report for Build 2017898581
💛 - Coveralls |
|
Ok so apparently this also happens if you just... not subscribe to the |
|
Thanks @Darkhogg did you get time of adding test and fixing merge conflicts. |
avkos
approved these changes
Apr 11, 2022
nazarhussain
approved these changes
Apr 11, 2022
nazarhussain
requested changes
Apr 11, 2022
There was a problem hiding this comment.
@Darkhogg Please convert the draft PR to ready and then request the request again.
jdevcs
reviewed
Apr 27, 2022
| @@ -306,7 +306,7 @@ Method.prototype._confirmTransaction = function (defer, result, payload) { | |||
| } | |||
|
|
|||
| // check if confirmation listener exists | |||
| if (defer.eventEmitter.listeners('confirmation').length > 0) { | |||
| if (!canUnsubscribe || defer.eventEmitter.listeners('confirmation').length > 0) { | |||
There was a problem hiding this comment.
Pending items are ( tests cases and fixing merge conflicts ). There is no activity on this PR from contributor so closing. @Darkhogg feel free to reopen and fix issues in this PR when have time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes, the checkConfirmation login became completely stuck and unable to exit properly, wasting a lot of CPU cycles and API calls on nothing.
I've seen this behaviour in situations where the generations of new blocks was slow (in which case polling kicks in and both polling and subscription remained working, but only one of them would ever finish) and when using
.once('confirmation')on the result of asendSignedTransactioncall.This PR fixes the afforementioned cases in the most simple way I came up with that doesn't break other stuff.
Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.