Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates on README.md Format #5115

Merged
merged 6 commits into from
Jun 28, 2022
Merged

Updates on README.md Format #5115

merged 6 commits into from
Jun 28, 2022

Conversation

mujeeb-kalwar
Copy link

@mujeeb-kalwar mujeeb-kalwar commented Jun 8, 2022

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

Small Changes in Readme File

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@jdevcs jdevcs added 1.x 1.0 related issues Future Release For future release. labels Jun 9, 2022
Copy link
Contributor

@nazarhussain nazarhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mujeebullahkalwar Please add an entry to CHANGELOG.me for the relevant change.

@nazarhussain nazarhussain added the Needs Clarification Requires additional input label Jun 22, 2022
Added required entry in `CHANGELOG.md` file
@mujeeb-kalwar
Copy link
Author

@mujeebullahkalwar Please add an entry to CHANGELOG.me for the relevant change.

Added

@nazarhussain nazarhussain removed the Needs Clarification Requires additional input label Jun 22, 2022
@nikoulai nikoulai self-requested a review June 23, 2022 08:04
@jdevcs jdevcs merged commit aae9d4a into web3:1.x Jun 28, 2022
@mujeeb-kalwar mujeeb-kalwar deleted the small-updates branch June 28, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Future Release For future release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants