Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.d.ts #5260

Merged
merged 9 commits into from
Sep 20, 2022
Merged

Update index.d.ts #5260

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
eb15b1b
Update CHANGELOG.md
nazarhussain Jul 18, 2022
32fa296
Update index.d.ts (#4955)
bigbizze Jul 18, 2022
ecb32d2
Update CHANGELOG.md
nazarhussain Jul 18, 2022
859cb98
Update CHANGELOG.md
nazarhussain Jul 18, 2022
5213b53
Apply suggestions from code review
nazarhussain Jul 19, 2022
34af389
Merge branch '1.x' into nazarhussain-patch-1
nikoulai Jul 20, 2022
c9de4db
Merge branch '1.x' into nazarhussain-patch-1
Aug 20, 2022
2523bb8
Merge branch '1.x' into nazarhussain-patch-1
avkos Sep 20, 2022
1d09e1b
fix CHANGELOG
avkos Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,3 +584,13 @@ Released with 1.0.0-beta.37 code base.
### Security
- Updated `got` lib version and fixed other libs using npm audit fix (#5178) (#5254)

## [Unreleased]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the previous version (1.7.5) was not released yet, is it possible to add those changes to 1.7.5-rc.0? Or would that violate the process?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was code freeze from our perspective, so we can't make any changes to it. The current workflow is to include the PR's in future release during the code freeze duration.


## [1.7.6]

### Changed

### Fixed
- Fixed types for getPastEvents (#4955) (#5260)


4 changes: 2 additions & 2 deletions packages/web3-eth-contract/types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,12 @@ export class Contract {
getPastEvents(
event: string,
options: PastEventOptions,
callback: (error: Error, event: EventData) => void
callback: (error: Error, events: EventData[]) => void
): Promise<EventData[]>;
getPastEvents(event: string, options: PastEventOptions): Promise<EventData[]>;
getPastEvents(
event: string,
callback: (error: Error, event: EventData) => void
callback: (error: Error, events: EventData[]) => void
): Promise<EventData[]>;
}

Expand Down