-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update node versions #5354
update node versions #5354
Conversation
Your Render PR Server URL is https://web3-js-pr-5354.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cbu1dfs41ls8fdb1ku70. |
Pull Request Test Coverage Report for Build 2878018154
💛 - Coveralls |
074529d
to
0ea714c
Compare
LGTM, for :
wts are error logs? |
Is this duplicate PR #5314 ? For current PR, also mention it in changelog. Thanks |
@jdevcs when using node 14 and node 16 node-gyp has an error installing and mosaic has a test contract error. heres the CI |
@jdevcs yes is a duplicate, will close the other |
#4888 Updating node version for builds and fixing mosaic tests that were failing due to node 12 version. Was running into issues trying to include more node versions with what seemed like random 1-2 test cases failing
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
with success.dist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.