Nikos/5071/investigate signtransaction testcases #5377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://web3-js-pr-5377.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cc33b17ho1ks6o3hkrtg. |
Pull Request Test Coverage Report for Build 2971408301Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
nikoulai
force-pushed
the
nikos/5071/investigate-signtransaction-testcases
branch
from
09f5e2f
to
d80552f
Compare
nikoulai
requested review from
nazarhussain,
luu-alex,
avkos,
jdevcs,
Muhammad-Altabba and
spacesailor24
|
bigints casted into strings should be fine though no? I think the issue is that some part where the bigint will be turned into a number, thats when we get smaller values. If thats the issue it wont be breaking |
avkos
approved these changes
Aug 29, 2022
jdevcs
reviewed
Aug 31, 2022
jdevcs
approved these changes
Sep 6, 2022
nikoulai
deleted the
nikos/5071/investigate-signtransaction-testcases
branch
This was referenced Oct 23, 2022
This was referenced Jan 2, 2023
This was referenced Feb 15, 2023
This was referenced Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#5071 part 1: r and v values in testcases don't align with
signTransactionresults.In two testcases r and v were wrong (they were even the same between the tests).
signTransactionreturns the right values (cross checked with external libraries, too)Discussion:
r and s are
bigints inethereumjsand we cast them to strings. This leads to some values with smaller values to be of smaller length when casted to string (missing leading 0s). I think, we should prepend them, but, this could be a breaking change for some users and better leave them as they are.