Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: using provided gas options for eip-1559 tx (#5012) #5418

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Sep 6, 2022

Description

For e2e tests of #5012

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist for 1.x:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

Checklist for 4.x:

  • I have selected the correct 4.x base branch.
  • Within the description, the feature or issue is discussed in detail or an issue is linked.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added any required tests for the changes I made
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules.
  • I ran yarn successfully
  • I ran yarn lint successfully
  • I ran yarn build:web successfully
  • I ran yarn test:unit successfully
  • I ran yarn test:integration successfully
  • I ran compile:contracts successfully
  • I have tested my code.
  • I have updated the corresponding CHANGELOG.md file in the packages I have edited.

* Update: using provided gas options for eip-1559 tx

* Add test and CHANGELOG for eth.accounts.signTransaction eip-1559 tx

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com>
@jdevcs jdevcs self-assigned this Sep 6, 2022
@render
Copy link

render bot commented Sep 6, 2022

@jdevcs jdevcs marked this pull request as ready for review September 6, 2022 13:35
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3000579753

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 81 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 74.518%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/web3-eth-accounts/src/index.js 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
packages/web3-eth-accounts/lib/index.js 27 85.62%
packages/web3-eth-accounts/src/index.js 54 23.05%
Totals Coverage Status
Change from base Build 3000398727: -0.06%
Covered Lines: 3274
Relevant Lines: 4140

💛 - Coveralls

@jdevcs
Copy link
Contributor Author

jdevcs commented Sep 6, 2022

All code changes of this PR are approved in #5012 and all tests are passing here, so merging into 1.x

@jdevcs jdevcs merged commit f07bae2 into 1.x Sep 6, 2022
@jdevcs jdevcs deleted the junaid/5012eip1559optionsusageimprovemente2e branch September 6, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants