Init web3-test-utils Package
#5426
Conversation
|
Your Render PR Server URL is https://web3js-docs-pr-5426.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ccg0adsgqg4cdq4trpn0. |
|
This pull request introduces 1 alert when merging 56d0609 into bc39fe9 - view on LGTM.com new alerts:
|
| @@ -104,6 +104,7 @@ export class Web3Context< | |||
| | SupportedProviders<API> | |||
| | Web3ContextInitOptions<API, RegisteredSubs>, | |||
| ) { | |||
| console.log(providerOrContext) | |||
There was a problem hiding this comment.
I think its for local debugging so should be removed?
There was a problem hiding this comment.
Yes this PR is still a draft and not ready for review
| @@ -37,7 +37,8 @@ | |||
| "jest-when": "^3.5.1", | |||
| "prettier": "^2.7.1", | |||
| "ts-jest": "^28.0.7", | |||
| "typescript": "^4.7.4" | |||
| "typescript": "^4.7.4", | |||
| "web3-test-utils": "0.1.0-alpha.0" | |||
There was a problem hiding this comment.
This will create cyclic dependency? as testing utils will use accounts pkg for account creation.
| @@ -42,7 +42,8 @@ | |||
| "typescript": "^4.7.4", | |||
| "web3-eth-abi": "^4.0.1-alpha.0", | |||
| "web3-eth-accounts": "^4.0.1-alpha.0", | |||
| "web3-providers-http": "^4.0.1-alpha.0" | |||
| "web3-providers-http": "^4.0.1-alpha.0", | |||
| "web3-test-utils": "0.1.0-alpha.0" | |||
There was a problem hiding this comment.
same here, cyclic dependency question?
| return { address: newAccount.address, privateKey: newAccount.privateKey }; | ||
| } | ||
|
|
||
| const fundGethAccount = async (fundeeAddress: Address, fundAmount: BigInt) => { |
There was a problem hiding this comment.
Mostly logic for funding test accounts will remain same, we just can pass from address ( or coinbase in case of geth, or one of 10 pre funded ganache acct) or any provided by user. so can we omit diff implementation for diff nodes.
|
This pull request introduces 1 alert when merging 6e0210e into 7e236d0 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 4b23a08 into 7e236d0 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 0d1c8b1 into 7e236d0 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 1291e52 into 7e236d0 - view on LGTM.com new alerts:
|
No description provided.