-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use subscription at rejectIfBlockTimeout
when the provider supports subscription
#5481
Merged
Muhammad-Altabba
merged 29 commits into
4.x
from
feature/5467/use-subscription-at-rejectIfBlockTimeout-when-the-provider-supports-subscription
Oct 25, 2022
Merged
Use subscription at rejectIfBlockTimeout
when the provider supports subscription
#5481
Muhammad-Altabba
merged 29 commits into
4.x
from
feature/5467/use-subscription-at-rejectIfBlockTimeout-when-the-provider-supports-subscription
Oct 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(will be updated when implementing #5482)
Muhammad-Altabba
changed the title
[DRAFT]
Use subscription at Oct 6, 2022
rejectIfBlockTimeout
when the provider supports subscription
1 task
1 task
…ror` only when `enableExperimentalFeatures` + re-enable some skipped tests
Muhammad-Altabba
requested review from
avkos,
jdevcs,
luu-alex and
spacesailor24
and removed request for
avkos
October 11, 2022 16:01
avkos
approved these changes
Oct 17, 2022
avkos
requested changes
Oct 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests stuck (360m)
…kTimeout-when-the-provider-supports-subscription
Those tests were not related to this MR. And they pass now after merging with the newest 4.x, as they are fixed and merged separately in different MRs. |
avkos
approved these changes
Oct 24, 2022
luu-alex
reviewed
Oct 25, 2022
luu-alex
reviewed
Oct 25, 2022
Co-authored-by: Alex <alex.luu@mail.utoronto.ca>
nikoulai
approved these changes
Oct 25, 2022
…tionWhenCheckingBlockTimeout`
Co-authored-by: Nikos Iliakis <nikoulai@users.noreply.github.com>
…kTimeout-when-the-provider-supports-subscription
Muhammad-Altabba
deleted the
feature/5467/use-subscription-at-rejectIfBlockTimeout-when-the-provider-supports-subscription
branch
October 25, 2022 10:19
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements #5467. In addition to a few code enhancements at tests.
However, because having lots of subscriptions and the tests are running in parallel some other issues showed up: #5517 and #5519 (and a related suggestion is interduced at #5521). And so this MR introduced a new config variable called
enableExperimentalFeatures
that containsuseSubscriptionWhenCheckingBlockTimeout
and the logic of this MR will run only whenenableExperimentalFeatures.useSubscriptionWhenCheckingBlockTimeout
istrue
. And tests are written for this accordingly.Type of change
Checklist for 1.x:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
with success.dist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.Checklist for 4.x:
yarn
successfullyyarn lint
successfullyyarn build:web
successfullyyarn test:unit
successfullyyarn test:integration
successfullycompile:contracts
successfullyCHANGELOG.md
file in the packages I have edited.