-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump util from 0.12.0 to 0.12.5 #5691
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wobsoriano
changed the title
chore(deps): bump util from 0.12.0 to 0.12.4
chore(deps): bump util from 0.12.0 to 0.12.5
Dec 7, 2022
Muhammad-Altabba
requested review from
Muhammad-Altabba,
avkos,
jdevcs,
luu-alex,
nikoulai and
spacesailor24
December 7, 2022 22:35
Hi there @wobsoriano thanks for the PR it looks good. Can you remove the package-lock.json and dist folder changes? those shouldn't be included |
This reverts commit 3e98110.
Done @luu-alex! |
👍 |
Pull Request Test Coverage Report for Build 3646032828
💛 - Coveralls |
This was referenced Dec 8, 2022
Merged
nikoulai
approved these changes
Dec 9, 2022
Thank you for the contribution, it has been merged :) #5700 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumps
web3-core-requestmanager
util dependency from v0.12.0 to v0.12.5. Mostly bug and security fixes happened from 0.12.0 to 0.12.5 and should not have any breaking changes. This could also fix the issue #4992.Type of change
Checklist for 1.x:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
with success.dist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.