Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update web3-eth-accounts.rst #5810

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Update web3-eth-accounts.rst #5810

merged 1 commit into from
Feb 8, 2023

Conversation

luu-alex
Copy link
Contributor

@luu-alex luu-alex commented Feb 5, 2023

Description

#5674
This PR changes the examples from number to string, should be using number string instead of number
Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist for 1.x:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

Checklist for 4.x:

  • I have selected the correct 4.x base branch.
  • Within the description, the feature or issue is discussed in detail or an issue is linked.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added any required tests for the changes I made
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules.
  • I ran yarn successfully
  • I ran yarn lint successfully
  • I ran yarn build:web successfully
  • I ran yarn test:unit successfully
  • I ran yarn test:integration successfully
  • I ran compile:contracts successfully
  • I have tested my code.
  • I have updated the corresponding CHANGELOG.md file in the packages I have edited.

Copy link
Contributor

@Muhammad-Altabba Muhammad-Altabba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @luu-alex for handling this community member MR.
Actually, to handle the fact that community members' MRs do not pass the pipeline checks, you could do the following (And I hope I am recalling the correct steps. And you could check this yourself):

  1. Create a new branch
  2. cherry-pick the commits from the original MR.
  3. Open an MR to merge your branch.

This way the history of the commits will be preserved 😄 . And if I could recall correctly, if you did not close the original MR and just kept it open. It will be automatically marked as "Merged" by GitHub after your MR got merged. This is because all the commits of the original MR will be indirectly merged through your MR.

@luu-alex
Copy link
Contributor Author

luu-alex commented Feb 6, 2023

@Muhammad-Altabba Thank you for the review :)
The original MR was not correct and the user who created it closed it. this Issue was getting stale so I just ended up doing it. You are correct that this isnt being run properly and ill need to close this. thanks

@luu-alex luu-alex closed this Feb 6, 2023
@luu-alex luu-alex reopened this Feb 6, 2023
@luu-alex
Copy link
Contributor Author

luu-alex commented Feb 6, 2023

@Muhammad-Altabba ah the pipelines do not run as no code was changed. This MR is still valid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants