-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gas
and input
instead of gasLimit
and data
#5915
Conversation
Deploying with Cloudflare Pages
|
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
So there seems to be a side effect from updating |
…t can be used to format transactionInfo types objs
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #5915 +/- ##
==========================================
+ Coverage 81.84% 81.86% +0.01%
==========================================
Files 137 137
Lines 5971 5983 +12
Branches 1571 1574 +3
==========================================
+ Hits 4887 4898 +11
- Misses 1084 1085 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
signTransaction
now always returns gas
instead of gasLimit
gas
and input
instead of gasLimit
and data
Changed
web3-core
data
property is passed totxInputOptionsFormatter
, it will now be replaced withinput
(Usegas
andinput
instead ofgasLimit
anddata
#5915)web3-errors
gasLimit
is no longer accepted as a parameter forMissingGasError
andTransactionGasMismatchError
, and is also no longer included in error message (Usegas
andinput
instead ofgasLimit
anddata
#5915)web3-eth
signTransaction
will now returngas
instead ofgasLimit
for returned transaction object regardless of what property name the provider uses (Usegas
andinput
instead ofgasLimit
anddata
#5915)formatTransaction
will now replacedata
transaction property withinput
(Usegas
andinput
instead ofgasLimit
anddata
#5915)isTransactionCall
will now check ifvalue.input
isHexStrict
if provided (Usegas
andinput
instead ofgasLimit
anddata
#5915)web3-eth-contract
getSendTxParams
will now returninput
instead ofdata
in returned transaction parameters object (Usegas
andinput
instead ofgasLimit
anddata
#5915)Contract
constructor will now thrown newContractTransactionDataAndInputError
if bothdata
andinput
are passed inContractInitOptions
forContract
constructor (Usegas
andinput
instead ofgasLimit
anddata
#5915)web3-types
data
property inTransactionOutput
was renamed toinput
(Usegas
andinput
instead ofgasLimit
anddata
#5915)Added
web3-eth-contract
input
is now an acceptable property forContractInitOptions
in place ofdata
(either can be used, butinput
is used withing theContract
class) (Usegas
andinput
instead ofgasLimit
anddata
#5915)Removed
web3-eth-contract
data
was removed as a property ofContractOptions
type (Usegas
andinput
instead ofgasLimit
anddata
#5915)closes #5387