added the functionality to introduce different timeout value for Web3… #6336
Conversation
shubhamshd
requested review from
avkos,
jdevcs,
luu-alex and
Muhammad-Altabba
as code owners
| if (this.requests.length === 0) { | ||
| return Promise.resolve([]); | ||
| } | ||
|
|
||
| const request = new Web3DeferredPromise<JsonRpcBatchResponse<unknown, unknown>>({ | ||
| timeout: DEFAULT_BATCH_REQUEST_TIMEOUT, | ||
| timeout: options?.timeout ?? DEFAULT_BATCH_REQUEST_TIMEOUT, |
There was a problem hiding this comment.
thanks for your contribution. This should be mentioned in changelog.
There was a problem hiding this comment.
apologies @jdevcs are you suggesting any change?
There was a problem hiding this comment.
@jdevcs Was the checklist not necessary? I couldn't even build the project and therefore abandoned the task.
There was a problem hiding this comment.
apologies @jdevcs are you suggesting any change?
This should be added in changelog files : https://github.com/shubhamshd/web3.js/blob/4.x/packages/web3-core/CHANGELOG.md and https://github.com/shubhamshd/web3.js/blob/4.x/packages/web3/CHANGELOG.md
There was a problem hiding this comment.
@jdevcs Was the checklist not necessary? I couldn't even build the project and therefore abandoned the task.
Could you share problems you were stuck? Most of items are also checks in CI ( lint, build, tests etc)
There was a problem hiding this comment.
apologies @jdevcs are you suggesting any change?
This should be added in changelog files : https://github.com/shubhamshd/web3.js/blob/4.x/packages/web3-core/CHANGELOG.md and https://github.com/shubhamshd/web3.js/blob/4.x/packages/web3/CHANGELOG.md
Ok I just need to update the changelog files right ? under unreleased section?
I'll just create new commit and update the existing pr thanks @jdevcs
There was a problem hiding this comment.
yes, please update these changelog files
There was a problem hiding this comment.
Due to recent release there are some file conflicts,
could you see those, or one of our team member can fix if you dnt have time. I am approving PR but I'll merge PR after fixes. Thanks
There was a problem hiding this comment.
@jdevcs I have resolved the conflict and updated the pr
Could you please review this now and merge, thanks!!!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6336 +/- ##
=======================================
Coverage 89.10% 89.11%
=======================================
Files 199 199
Lines 7722 7723 +1
Branches 2127 2128 +1
=======================================
+ Hits 6881 6882 +1
Misses 841 841
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| if (this.requests.length === 0) { | ||
| return Promise.resolve([]); | ||
| } | ||
|
|
||
| const request = new Web3DeferredPromise<JsonRpcBatchResponse<unknown, unknown>>({ | ||
| timeout: DEFAULT_BATCH_REQUEST_TIMEOUT, | ||
| timeout: options?.timeout ?? DEFAULT_BATCH_REQUEST_TIMEOUT, |
There was a problem hiding this comment.
yes, please update these changelog files
…BatchRequest
Description
This change adds the functionality in execute method of Web3BatchRequest class to set timeout value other than the default one.
Fixes #6190
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.