Fix an issue with detecting Uint8Array #6486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndefined-is-not-a-constructor-or-null
…ndefined-is-not-a-constructor-or-null
…ndefined-is-not-a-constructor-or-null
…ndefined-is-not-a-constructor-or-null
…ndefined-is-not-a-constructor-or-null
…ndefined-is-not-a-constructor-or-null
…ndefined-is-not-a-constructor-or-null
(fix: `value "..." at "/0" must pass "bytes" validation`)
Muhammad-Altabba
changed the title
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Deploying with
|
| Latest commit: |
7ec6a95
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://35d48ab5.web3-js-docs.pages.dev |
| Branch Preview URL: | https://6393-web3validatorerror-erro.web3-js-docs.pages.dev |
…s-not-a-constructor-or-null' into 6393-web3validatorerror-error-value-at-0-must-pass-bytes-validation
|
To resume working on this after merging: #6398 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6486 +/- ##
==========================================
- Coverage 91.46% 91.44% -0.03%
==========================================
Files 214 214
Lines 8155 8171 +16
Branches 2193 2200 +7
==========================================
+ Hits 7459 7472 +13
- Misses 696 699 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
17 tasks
…-pass-bytes-validation
…-pass-bytes-validation
Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
avkos
approved these changes
Jan 4, 2024
…-pass-bytes-validation
…-pass-bytes-validation
luu-alex
approved these changes
Jan 8, 2024
Muhammad-Altabba
deleted the
6393-web3validatorerror-error-value-at-0-must-pass-bytes-validation
branch
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix error:
value "..." at "/0" must pass "bytes" validation.[UPDATE: sorry it tagged an unrelated issue by mistake. Now I correct it]
Suppose to close: #6393
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.