Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/4.2.2 #6562

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Release/4.2.2 #6562

merged 3 commits into from
Nov 3, 2023

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Nov 2, 2023

[4.2.2]

Added

web3-core

web3-types

Changed

web3

  • Dependencies updated

Fixed

web3-errors

web3-eth-contract

@jdevcs jdevcs added Release 4.x 4.0 related labels Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #6562 (a616752) into 4.x (4358140) will increase coverage by 2.19%.
Report is 96 commits behind head on 4.x.
The diff coverage is 93.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #6562      +/-   ##
==========================================
+ Coverage   87.37%   89.56%   +2.19%     
==========================================
  Files         197      215      +18     
  Lines        7548     8251     +703     
  Branches     2059     2234     +175     
==========================================
+ Hits         6595     7390     +795     
+ Misses        953      861      -92     
Flag Coverage Δ
UnitTests 89.56% <93.06%> (+2.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

Copy link

github-actions bot commented Nov 2, 2023

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 587 KB 587 KB 0 0.00%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Old size New size Diff Diff %
web3.min.js 570 KB 570 KB 0 0.00%
../lib/commonjs/index.d.ts 8.56 KB 8.56 KB 0 0.00%
../lib/commonjs/accounts.d.ts 3.67 KB 3.67 KB 0 0.00%
../lib/commonjs/types.d.ts 2.45 KB 2.45 KB 0 0.00%
../lib/commonjs/web3.d.ts 1.14 KB 1.14 KB 0 0.00%
../lib/commonjs/abi.d.ts 1000 bytes 1000 bytes 0 0.00%
../lib/commonjs/eth.exports.d.ts 280 bytes 280 bytes 0 0.00%
../lib/commonjs/providers.exports.d.ts 148 bytes 148 bytes 0 0.00%
../lib/commonjs/version.d.ts 60 bytes 60 bytes 0 0.00%

@luu-alex
Copy link
Contributor

luu-alex commented Nov 2, 2023

https://github.com/web3/web3.js/actions/runs/6732417536/job/18299078974 deploy failing, looks like an auth issue?
https://github.com/web3/web3.js/actions/runs/6732436793/job/18299315033#step:5:303 some validator test failing, did these fail before?

Copy link
Contributor

@avkos avkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except @luu-alex comments

@jdevcs
Copy link
Contributor Author

jdevcs commented Nov 2, 2023

https://github.com/web3/web3.js/actions/runs/6732417536/job/18299078974 deploy failing, looks like an auth issue?

we can fix it in another PR

https://github.com/web3/web3.js/actions/runs/6732436793/job/18299315033#step:5:303 some validator test failing, did these fail before?

Its passing now, was due to some validation unit tests consuming more time,

@luu-alex

@jdevcs jdevcs marked this pull request as ready for review November 2, 2023 15:01
@jdevcs jdevcs merged commit 72e9bbd into 4.x Nov 3, 2023
110 of 117 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x 4.0 related Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants