-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decode ABI method added #6690
Decode ABI method added #6690
Conversation
@@ -1116,6 +1116,7 @@ export class Contract<Abi extends ContractAbi> | |||
}), | |||
|
|||
encodeABI: () => encodeMethodABI(methodAbi, abiParams), | |||
decodeABI: (data?: string) => decodeMethodReturn(methodAbi, data), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for you contribution,
Could you please, mention this added functionality in the related CHANGELOG.md file?
And could you please add a Unit test for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jerkly Thanks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6690 +/- ##
==========================================
+ Coverage 87.37% 91.95% +4.57%
==========================================
Files 197 215 +18
Lines 7548 8201 +653
Branches 2059 2214 +155
==========================================
+ Hits 6595 7541 +946
+ Misses 953 660 -293
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except @Muhammad-Altabba comment. Thanks for your contribution
Hi @jerkly, |
This PR has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment. |
The work for this change will be done at #6950 |
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Fixes #6220
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.