Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode ABI method added #6690

Closed
wants to merge 4 commits into from
Closed

Decode ABI method added #6690

wants to merge 4 commits into from

Conversation

jerkly
Copy link

@jerkly jerkly commented Jan 4, 2024

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Fixes #6220

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@@ -1116,6 +1116,7 @@ export class Contract<Abi extends ContractAbi>
}),

encodeABI: () => encodeMethodABI(methodAbi, abiParams),
decodeABI: (data?: string) => decodeMethodReturn(methodAbi, data),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you contribution,
Could you please, mention this added functionality in the related CHANGELOG.md file?
And could you please add a Unit test for this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jerkly Thanks

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Merging #6690 (b7ff4b4) into 4.x (4358140) will increase coverage by 4.57%.
Report is 212 commits behind head on 4.x.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #6690      +/-   ##
==========================================
+ Coverage   87.37%   91.95%   +4.57%     
==========================================
  Files         197      215      +18     
  Lines        7548     8201     +653     
  Branches     2059     2214     +155     
==========================================
+ Hits         6595     7541     +946     
+ Misses        953      660     -293     
Flag Coverage Δ
UnitTests 91.95% <0.00%> (+4.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

Copy link
Contributor

@avkos avkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except @Muhammad-Altabba comment. Thanks for your contribution

@Muhammad-Altabba
Copy link
Contributor

Hi @jerkly,
Do you like to finalize this PR?
Many thanks,

Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label Mar 30, 2024
@Muhammad-Altabba
Copy link
Contributor

The work for this change will be done at #6950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add method decodeAbi to method interface
4 participants