Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added comaparison for package size #6852

Closed
wants to merge 4 commits into from
Closed

Added comaparison for package size #6852

wants to merge 4 commits into from

Conversation

DrParadox05
Copy link
Contributor

Description

This change resolves #6781 by adding an image to compare size of various bundles and including 1 more feature in the "Features of Web3.js v4" section of docs.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

codecov bot commented Mar 3, 2024

Codecov Report

Merging #6852 (aaf92d4) into 4.x (4358140) will increase coverage by 4.68%.
Report is 224 commits behind head on 4.x.
The diff coverage is n/a.

❗ Current head aaf92d4 differs from pull request most recent head c27cf95. Consider uploading reports for the commit c27cf95 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #6852      +/-   ##
==========================================
+ Coverage   87.37%   92.06%   +4.68%     
==========================================
  Files         197      215      +18     
  Lines        7548     8212     +664     
  Branches     2059     2208     +149     
==========================================
+ Hits         6595     7560     +965     
+ Misses        953      652     -301     
Flag Coverage Δ
UnitTests 92.06% <ø> (+4.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@DrParadox05
Copy link
Contributor Author

Hey @jdevcs i've updated the PR with requested changes, please check

@avkos avkos requested a review from jdevcs March 14, 2024 14:08
Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

web3 and other libs size change slightly in each release so this will need updates each time, I think this shouldn't part of doc

@jdevcs
Copy link
Contributor

jdevcs commented Apr 22, 2024

web3 and other libs size change slightly in each release so this will need updates each time, I think this shouldn't part of doc

@deepak2030 if you remove size image we can merge this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlight web3.js features [docs/articles]
4 participants