Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result of contract method .send is hard to type #6883

Merged
merged 11 commits into from
Mar 15, 2024

Conversation

avkos
Copy link
Contributor

@avkos avkos commented Mar 12, 2024

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Fixes #6701

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

github-actions bot commented Mar 12, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 618.52 kB → 618.57 kB (+56 B) +0.01%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
../lib/commonjs/index.d.ts 8.63 kB → 8.69 kB (+56 B) +0.63%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 599.51 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.45 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

github-actions bot commented Mar 12, 2024

Benchmark

Benchmark suite Current: 0b95837 Previous: 6c075db Ratio
processingTx 9547 ops/sec (±4.38%) 9301 ops/sec (±4.81%) 0.97
processingContractDeploy 41245 ops/sec (±7.60%) 39129 ops/sec (±7.62%) 0.95
processingContractMethodSend 20013 ops/sec (±5.67%) 19443 ops/sec (±5.19%) 0.97
processingContractMethodCall 40459 ops/sec (±4.84%) 38971 ops/sec (±6.34%) 0.96
abiEncode 45072 ops/sec (±6.41%) 44252 ops/sec (±6.92%) 0.98
abiDecode 32204 ops/sec (±6.91%) 30419 ops/sec (±8.89%) 0.94
sign 1647 ops/sec (±1.28%) 1656 ops/sec (±4.08%) 1.01
verify 367 ops/sec (±2.64%) 373 ops/sec (±0.78%) 1.02

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Merging #6883 (0b95837) into 4.x (383af39) will not change coverage.
Report is 1 commits behind head on 4.x.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #6883   +/-   ##
=======================================
  Coverage   91.99%   91.99%           
=======================================
  Files         215      215           
  Lines        8172     8172           
  Branches     2202     2202           
=======================================
  Hits         7518     7518           
  Misses        654      654           
Flag Coverage Δ
UnitTests 91.99% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdevcs
Copy link
Contributor

jdevcs commented Mar 14, 2024

also add in changelog @avkos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Result of contract method .send is hard to type
3 participants