-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4.7.0 #6934
v4.7.0 #6934
Conversation
Deploying web3-js-docs with Cloudflare Pages
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6934 +/- ##
=======================================
Coverage 91.95% 91.95%
=======================================
Files 215 215
Lines 8188 8188
Branches 2208 2208
=======================================
Hits 7529 7529
Misses 659 659
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls check failing unit tests should be passing before release, and these are not having any new error? @luu-alex
Had a discussion with @jdevcs it seems like the failing test of getTransactionFromBlock earliest is probably due to the rpc endpoint which is why its retuning null and doesnt seem to be an issue, all other failing test cases that are related to unit tests are unconsistent tests which are recognized as not a problem so ill continue with release |
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.