Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.7.0 #6934

Merged
merged 1 commit into from
Mar 26, 2024
Merged

v4.7.0 #6934

merged 1 commit into from
Mar 26, 2024

Conversation

luu-alex
Copy link
Contributor

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

Deploying web3-js-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7379a3b
Status: ✅  Deploy successful!
Preview URL: https://778fd18a.web3-js-docs.pages.dev
Branch Preview URL: https://head.web3-js-docs.pages.dev

View logs

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Merging #6934 (7379a3b) into 4.x (c4e039a) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #6934   +/-   ##
=======================================
  Coverage   91.95%   91.95%           
=======================================
  Files         215      215           
  Lines        8188     8188           
  Branches     2208     2208           
=======================================
  Hits         7529     7529           
  Misses        659      659           
Flag Coverage Δ
UnitTests 91.95% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

Copy link

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 619.33 kB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 600.27 kB 0%
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.45 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

Benchmark

Benchmark suite Current: 7379a3b Previous: 6c075db Ratio
processingTx 9268 ops/sec (±3.96%) 9301 ops/sec (±4.81%) 1.00
processingContractDeploy 38086 ops/sec (±6.58%) 39129 ops/sec (±7.62%) 1.03
processingContractMethodSend 19928 ops/sec (±6.74%) 19443 ops/sec (±5.19%) 0.98
processingContractMethodCall 40510 ops/sec (±5.73%) 38971 ops/sec (±6.34%) 0.96
abiEncode 44602 ops/sec (±6.94%) 44252 ops/sec (±6.92%) 0.99
abiDecode 30301 ops/sec (±8.36%) 30419 ops/sec (±8.89%) 1.00
sign 1602 ops/sec (±2.87%) 1656 ops/sec (±4.08%) 1.03
verify 379 ops/sec (±0.58%) 373 ops/sec (±0.78%) 0.98

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls check failing unit tests should be passing before release, and these are not having any new error? @luu-alex

@luu-alex
Copy link
Contributor Author

Had a discussion with @jdevcs it seems like the failing test of getTransactionFromBlock earliest is probably due to the rpc endpoint which is why its retuning null and doesnt seem to be an issue, all other failing test cases that are related to unit tests are unconsistent tests which are recognized as not a problem so ill continue with release

@luu-alex luu-alex merged commit a173a8f into 4.x Mar 26, 2024
93 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants