Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events guide 6741 #6983

Merged
merged 8 commits into from
Apr 18, 2024
Merged

Events guide 6741 #6983

merged 8 commits into from
Apr 18, 2024

Conversation

SantiagoDevRel
Copy link
Member

Issue #6741

pls confirm is this is correct like this:

  • on("data") - Fires on each incoming log with the log object as argument.
 subcription.on("data", (data) => console.log(data));
  • on("changed") - Fires on each log which was removed from the blockchain. The log will have the additional property "removed: true".
 subcription.on("changed", (changed) => console.log(changed));
  • on("error") - Fires when an error in the subscription occurs.
 subcription.on("error", (error) => console.log(error));
  • on("connected") - Fires once after the subscription successfully connected. Returns the subscription id.
 subcription.on("connected", (connected) => console.log(connected));

Copy link

github-actions bot commented Apr 17, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 622.84 kB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 603.77 kB 0%
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.45 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 19ecdec Previous: 6c075db Ratio
processingTx 9001 ops/sec (±3.95%) 9301 ops/sec (±4.81%) 1.03
processingContractDeploy 36675 ops/sec (±7.03%) 39129 ops/sec (±7.62%) 1.07
processingContractMethodSend 19118 ops/sec (±7.40%) 19443 ops/sec (±5.19%) 1.02
processingContractMethodCall 39455 ops/sec (±6.09%) 38971 ops/sec (±6.34%) 0.99
abiEncode 42834 ops/sec (±7.23%) 44252 ops/sec (±6.92%) 1.03
abiDecode 29241 ops/sec (±7.72%) 30419 ops/sec (±8.89%) 1.04
sign 1560 ops/sec (±3.40%) 1656 ops/sec (±4.08%) 1.06
verify 367 ops/sec (±0.62%) 373 ops/sec (±0.78%) 1.02

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Merging #6983 (4e732db) into 4.x (93296c2) will not change coverage.
The diff coverage is n/a.

❗ Current head 4e732db differs from pull request most recent head 19ecdec. Consider uploading reports for the commit 19ecdec to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #6983   +/-   ##
=======================================
  Coverage   91.97%   91.97%           
=======================================
  Files         215      215           
  Lines        8273     8273           
  Branches     2268     2268           
=======================================
  Hits         7609     7609           
  Misses        664      664           
Flag Coverage Δ
UnitTests 91.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants