Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nextjs problem #7216

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Fix nextjs problem #7216

merged 2 commits into from
Aug 23, 2024

Conversation

avkos
Copy link
Contributor

@avkos avkos commented Aug 23, 2024

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

github-actions bot commented Aug 23, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 639.24 kB → 639.17 kB (-69 B) -0.01%
Changeset
File Δ Size
../web3-eth-accounts/lib/commonjs/tx/transactionFactory.js 📉 -286 B (-5.01%) 5.57 kB → 5.29 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
web3.min.js 619.95 kB → 619.88 kB (-69 B) -0.01%

Unchanged

Asset File Size % Changed
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 7cc4f35 Previous: e746566 Ratio
processingTx 22875 ops/sec (±9.24%) 23728 ops/sec (±7.13%) 1.04
processingContractDeploy 39175 ops/sec (±7.18%) 40637 ops/sec (±7.66%) 1.04
processingContractMethodSend 17125 ops/sec (±7.03%) 16949 ops/sec (±7.02%) 0.99
processingContractMethodCall 27837 ops/sec (±7.21%) 28367 ops/sec (±7.27%) 1.02
abiEncode 44532 ops/sec (±6.78%) 46116 ops/sec (±6.72%) 1.04
abiDecode 29923 ops/sec (±7.41%) 31091 ops/sec (±7.58%) 1.04
sign 1546 ops/sec (±0.75%) 1587 ops/sec (±0.92%) 1.03
verify 367 ops/sec (±0.66%) 372 ops/sec (±2.74%) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.50%. Comparing base (e746566) to head (7cc4f35).
Report is 1 commits behind head on 4.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #7216      +/-   ##
==========================================
+ Coverage   94.48%   94.50%   +0.02%     
==========================================
  Files         216      216              
  Lines        8434     8429       -5     
  Branches     2317     2315       -2     
==========================================
- Hits         7969     7966       -3     
+ Misses        465      463       -2     
Flag Coverage Δ
UnitTests 94.50% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants