Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: init Web3HttpProvider without chain id #813

Closed
wants to merge 2 commits into from
Closed

fix: init Web3HttpProvider without chain id #813

wants to merge 2 commits into from

Conversation

zhangliugang
Copy link
Contributor

Summary of Changes

Fixes HTTP method

Test Data or Screenshots

By submitting this pull request, you are confirming the following:
  • I have reviewed the Contribution Guidelines.
  • I have performed a self-review of my own code.
  • I have updated my repository to match the develop branch.
  • I have included test data or screenshots that prove my fix is effective or that my feature works.
  • I have checked that all tests work and swiftlint is not throwing any errors/warnings.

@yaroslavyaroslav
Copy link
Collaborator

@zhangliugang Could you please elaborate the reasoning for these changes?

@zhangliugang
Copy link
Contributor Author

zhangliugang commented Aug 23, 2023 •
edited
Loading

@yaroslavyaroslav APIRequest.getNetwork.call returns RPC method name "net_version", not http method

@zhangliugang
Copy link
Contributor Author

Outdated, #831

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhangliugang @yaroslavyaroslav