Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSDOC 3 deprecation #126

Closed
JamesCullum opened this issue Apr 17, 2023 · 5 comments · Fixed by #131
Closed

JSDOC 3 deprecation #126

JamesCullum opened this issue Apr 17, 2023 · 5 comments · Fixed by #131
Assignees

Comments

@JamesCullum
Copy link
Member

If someone has experience with JSDOC 3 to 4 migrations - we are currently using v3, which is deprecated and has a vulnerable (dev)Dependency, and would highly appreciate having someone experienced migrate it to v4.

@Hexagon
Copy link
Member

Hexagon commented Jun 13, 2023

It should just be a matter of changing version number to ~4.0.0, npm i, and rebuild docs. 👍

Can not remember I had any issues upgrading my own packages.

https://github.com/jsdoc/jsdoc/blob/main/CHANGES.md

@JamesCullum
Copy link
Member Author

I created the issue after trying this and receiving dozen of errors - so its sadly not THAT easy

@Hexagon
Copy link
Member

Hexagon commented Jun 14, 2023

Oh. I can have a look at it then 👍

@Hexagon
Copy link
Member

Hexagon commented Jun 14, 2023

@JamesCullum about the problem at release, change deno
-version from 1.20.1 to 1.x just like the test pipeline

@JamesCullum
Copy link
Member Author

Thanks, done and works 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants