Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency update #131

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Dependency update #131

merged 1 commit into from
Jun 14, 2023

Conversation

Hexagon
Copy link
Member

@Hexagon Hexagon commented Jun 14, 2023

Full dependency update, including docdash and jsdoc 3 -> 4

Docs already published, as i had to test everything

Bumped revision version

Fixes #126

@Hexagon Hexagon requested a review from JamesCullum June 14, 2023 09:30
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (404fd71) 92.97% compared to head (85ea46d) 92.97%.

❗ Current head 85ea46d differs from pull request most recent head 6ee0779. Consider uploading reports for the commit 6ee0779 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #131   +/-   ##
=======================================
  Coverage   92.97%   92.97%           
=======================================
  Files          16       16           
  Lines        6007     6007           
=======================================
  Hits         5585     5585           
  Misses        422      422           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JamesCullum
Copy link
Member

Great, so just bumping fixed it? Great to hear, thanks - maybe my mistake was only bumping JSDOC

@JamesCullum JamesCullum merged commit 46e7d06 into master Jun 14, 2023
@Hexagon
Copy link
Member Author

Hexagon commented Jun 14, 2023

Yeah, the trick to avloid errors were to bump docdash along with jsdoc :)

@Hexagon Hexagon deleted the deps/jsdoc-4 branch June 14, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSDOC 3 deprecation
3 participants