-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: supporting android and ios rp origins #121
feat: supporting android and ios rp origins #121
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #121 +/- ##
==========================================
+ Coverage 92.95% 92.97% +0.01%
==========================================
Files 16 16
Lines 5992 6007 +15
==========================================
+ Hits 5570 5585 +15
Misses 422 422
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Hey @TomerDavid-Transmit thanks for the contribution! Are you trying to achieve the same thing as in #122 ? |
@JamesCullum yes, except for the prefix I think we should look for. #122 searches |
Very much needed addition! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution, was waiting for it for a long time!
looks like an encompassing code. |
LGTM 👍 This one is slightly more complete than #122 @JamesCullum 3.3.6 or 3.4.0? I think i vote for 3.3.6. |
Nice change! |
@Hexagon I think 3.4.0 would make more sense as new feature, as previously we didn't support it. Will merge and do it - thanks! |
While using the lib, I noticed that the
rpOrigin
, as returned by the android native fido2 client attestation response, is considered invalid.Made this change for the lib to support android FacetIDs as origins.
In depth explanation: https://fidoalliance.org/specs/uaf-v1.0-id-20141122/fido-appid-and-facets-v1.0-id-20141122.html#the-appid-and-facetid-assertions
Also added support for the iOS FacetID prefix, as specified in the fido2 docs above.
Empirically, our experiments with native iOS clients resulted with
https
rp origins - so the docs might be outdated, but I added the FacetID support just in case.