Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new certificates #151

Merged
merged 7 commits into from
Dec 22, 2023
Merged

Conversation

popeeyy
Copy link
Contributor

@popeeyy popeeyy commented Dec 18, 2023

Fix the parsing of new certificates from TruU and OneSpan (found in https://mds.fidoalliance.org)
Fixes issue #144

@JamesCullum
Copy link
Member

JamesCullum commented Dec 20, 2023

Thanks a lot for the debugging and PR!

Can you remove the package-lock from commit and bump the version in package.json to 3.4.4?

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (50ee8da) 92.85% compared to head (f6ffa95) 92.86%.
Report is 1 commits behind head on master.

❗ Current head f6ffa95 differs from pull request most recent head 193edd0. Consider uploading reports for the commit 193edd0 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #151   +/-   ##
=======================================
  Coverage   92.85%   92.86%           
=======================================
  Files          16       16           
  Lines        6019     6023    +4     
=======================================
+ Hits         5589     5593    +4     
  Misses        430      430           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamesCullum
Copy link
Member

Can you add a test case for the certificate that only works for your case? This would maintain the code coverage and make sure that future changes don't destroy it!

Then we are good to merge, thanks a lot for your help!

@JamesCullum JamesCullum merged commit de9e4a3 into webauthn-open-source:master Dec 22, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants