Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC call to check if given root is known root of merkle tree #327

Merged
merged 5 commits into from
May 5, 2023

Conversation

salman01zp
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Add RPC call to check if given root is known root

Reference issue to close (if applicable)

Closes #325

@salman01zp salman01zp requested review from 1xstj and shekohex May 4, 2023 14:37
@salman01zp salman01zp marked this pull request as ready for review May 4, 2023 14:38
Copy link
Collaborator

@shekohex shekohex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, good job!

Just a few rephrasing of the error messages and comments to make it more accurate in the context of the merkle root checking.

pallets/mt/rpc/runtime-api/src/lib.rs Outdated Show resolved Hide resolved
pallets/mt/rpc/src/error.rs Outdated Show resolved Hide resolved
pallets/mt/rpc/src/error.rs Outdated Show resolved Hide resolved
pallets/mt/rpc/src/error.rs Outdated Show resolved Hide resolved
@salman01zp salman01zp requested a review from shekohex May 4, 2023 17:37
Copy link
Collaborator

@shekohex shekohex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@shekohex shekohex merged commit 915b29e into main May 5, 2023
@shekohex shekohex deleted the salman/known-root-rpc-call branch May 5, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Add rpc api for is_known_root method
3 participants