This repository has been archived by the owner on Sep 20, 2019. It is now read-only.
Cooperate with ShadyCSS to appropriately scope changes to class/className #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 1, 2016 15:39
Conflicts: shadydom.min.js shadydom.min.js.map
dfreedm
suggested changes
Nov 9, 2016
| @@ -371,6 +350,14 @@ let nativeImportNode = Document.prototype.importNode; | |||
| let nativeSetAttribute = Element.prototype.setAttribute; | |||
| let nativeRemoveAttribute = Element.prototype.removeAttribute; | |||
|
|
|||
| export let setAttribute = function(attr, value) { | |||
There was a problem hiding this comment.
Why not take the node as the first argument?
setAttribute(node, attr, value) would remove the indirection used later.
| @@ -656,7 +643,7 @@ let ElementMixin = { | |||
|
|
|||
|
|
|||
| setAttribute(name, value) { | |||
| nativeSetAttribute.call(this, name, value); | |||
| setAttribute.call(this, name, value); | |||
There was a problem hiding this comment.
could be setAttribute(this, name, value)
| return this.getAttribute('class'); | ||
| }, | ||
| set(value) { | ||
| setAttribute.call(this, 'class', value); |
There was a problem hiding this comment.
setAttribute(this, 'class', value)
dfreedm
approved these changes
Nov 9, 2016
…`name` changes, (2) the `slot` attribute changed and the parent has a shadowRoot with insertion point. Previously any attribute change on a patched node would distribute if the parent had a shadowRoot with insertion points.
dfreedm
approved these changes
Nov 9, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements class/className setters for all elements using ShadyCSS's
setElementClass(element, classString)api to provide automatic style scoping whenclasschanges.Should not be merged before webcomponents/shadycss#25.