Remove trailing semicolon from err! macro #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the `semicolon_in_expressions_from_macros` lint is ever turned into a hard error, your crate will stop compiling. This commit ensures that your crate will compile on both current and future versions of Rust. See rust-lang/rust#79813 for more details
|
Thank you! 🙂 |
Closed
andersk
added a commit
to andersk/rome-tools
that referenced
this pull request
Feb 24, 2023
Fixes ‘warning: the following packages contain code that will be rejected by a future version of Rust: fs_extra v1.2.0’ from ‘cargo build’. webdesus/fs_extra#38 Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2 tasks
ematipico
pushed a commit
to rome/tools
that referenced
this pull request
Feb 24, 2023
Fixes ‘warning: the following packages contain code that will be rejected by a future version of Rust: fs_extra v1.2.0’ from ‘cargo build’. webdesus/fs_extra#38 Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
semicolon_in_expressions_from_macroslint is ever turned into ahard error, your crate will stop compiling. This commit ensures that
your crate will compile on both current and future versions of Rust.
See rust-lang/rust#79813 for more details