Cucumber 2 #60

lgandecki · 2017-05-29T17:27:25Z

Feedback/questions more than welcome!

…mmaticaly works

…ce for wdio-cucumber-framework

Cucumber2

…framework

…-framework into cucumberv2

christian-bromann

Some initial suggestions and questions

christian-bromann · 2017-05-29T17:30:01Z

README.md

@@ -14,7 +14,7 @@ The easiest way is to keep `wdio-cucumber-framework` as a devDependency in your
 ```json
 {
  "devDependencies": {
-    "wdio-cucumber-framework": "~0.2.0"
+    "wdio-cucumber-framework": "~1.0.0"


Maybe we should change line 8 to:

A WebdriverIO plugin. Adapter for CucumberJS v2 testing framework. To use v1 install this package with latest version v0.3.1.

christian-bromann · 2017-05-29T17:31:40Z

circle.yml

+test:
+  override:
+    - npm run test:ci
+    - ./node_modules/.bin/codeclimate-test-reporter < ./coverage/lcov.info


We used to use TravisCI for CI/CD .. if circle ci is free for open source stuff I don't mind staying with circle ci

since it's in this repo now it automatically works with travis, I personally prefer circle so I was going to use it in mine - I can remove this file, I'm assuming you use travis everywhere else so it doesn't make sense to break the pattern

I'm assuming you use travis everywhere else

that is the case

christian-bromann · 2017-05-29T17:35:58Z

lib/adapter.js

+        // native
+        string.match(/^async /) ||
+        // babel (this may change, but hey...)
+        string.match(/return _ref[^.]*\.apply/) ||


Not sure if we really want to do that. I think it is sophisticated enough when we check if the function name is async or the config is sync: false. If the user wants to use async/await we should expect him to turn sync off in the config.

it didn't work for me originally.. but I tried it now with just the fn.name === 'async' check and it passes the tests. Unless I'm missing some edge case I forgot about - you might be right and that check might be enough, removed this code now

christian-bromann · 2017-05-29T17:37:29Z

package.json

@@ -1,7 +1,7 @@
 {
  "name": "wdio-cucumber-framework",
-  "version": "0.3.1",
-  "description": "A WebdriverIO plugin. Adapter for Cucumber testing framework.",
+  "version": "1.0.0-beta.0",


If all existing tests have passed I am cool to just release it as 1.0.0. There will always be bug fixes and improvements.

Edit: unless the next release takes too long than we can release it as beta with the fork as dependency

makes sense

christian-bromann · 2017-05-29T17:39:46Z

package.json

@@ -39,7 +39,8 @@
  "homepage": "https://github.com/webdriverio/wdio-cucumber-framework#readme",
  "dependencies": {
    "babel-runtime": "~6.23.0",
-    "cucumber": "~1.3.1",
+    "cucumber": "lgandecki/cucumber-js#passOptionsToFunctionWrapperNPM",


I've seen the pending PR here: cucumber/cucumber-js#838
Let's wait for the v1.0.0 release until this is merged any published or maybe release it as beta and use the forked version.

…mber-framework into cucumberv2

… to the wrapper

…empty object

lgandecki · 2017-06-23T09:27:28Z

this uses the oficial cucumber2 now, I fixed tags as well (the syntax has changed between v1 and v2).
The remaining problem is that this doesn't automatically load step_definitions that are not listed in require opt. I will have to think about it a bit. I think how it worked with v1 was that step_definitions folder that was adjacent to a feature file was loaded recursively

lgandecki · 2017-06-23T09:28:06Z

what we've been using now is to have one "entry" file that we load in require section of the wdio.conf.js file, that loads everything else. But that doesn't seem optimal.

chuan-qin · 2017-07-12T14:21:11Z

Can't wait for this to get merged.

chuan-qin · 2017-07-12T17:37:30Z

lib/adapter.js

@@ -37,74 +41,83 @@ class CucumberAdapter {
        this.capabilities = capabilities

        this.cucumberOpts = Object.assign(DEFAULT_OPTS, config.cucumberOpts)


@lgandecki

// convert require path to files this.cucumberOpts.require = this.cucumberOpts.require.map(function (path) { if (path.match(/.*\*\*\/\*.js/)) return glob.sync(path, {cwd: process.cwd()}) if (path.match(/.*\.js/)) return path return glob.sync(path + '/**/*.js', {cwd: process.cwd()}) }).reduce(function (a, b) { return a.concat(b) }, [])

You can add something like this after this line.

This is to parse the cucumber require option. Please also add glob to import, and dependency in package.json.

By the way, is there a reason we are not using Cucumber.Cli directly?

Thanks for the tip @pantherqin and for the reminder that this is not merged yet! I'm about to try your suggestion and let you know how this goes.

as for CLI, per this comment:
cucumber/cucumber-js#786 (comment)

and also, I did start with CLI at first but I encountered some limitations that seemed almost impossible to solve (I can't recall right now, it was hundreds if not thousands of lines of code ago ;) ). Maybe there wasn't a way to attach custom listeners?

@lgandecki

Ya, understand it was not merged yet. I may want to use webdriverIO with cucumber 2 for a company project (pending boss approval :D).

Was using protractor with cucumber. You can have a look at https://github.com/protractor-cucumber-framework/protractor-cucumber-framework/blob/master/index.js if you want. I didn't read the code in too much detail yet, but it seem to work well using cucumber Cli for protractor with other hooks. Hope it helps :)

I guess this is a question for @christian-bromann
Do we want to allow globs in the require part of the wdio.conf?

Also, we could use similar code (with glob) to automatically import files from step_definitions/ folder, the way cucumber (and current wdio-cucumber-framework implementation) works, as far as I understand

Do we want to allow globs in the require part of the wdio.conf?

If it is complaint to the behavior of Cucumber, then yes

Disables "replacing existing mock" warning

christian-bromann

This is great! Even though this has some outstanding questions, let's merge this and glo forward. Thanks so much @lgandecki

christian-bromann · 2017-08-16T10:00:26Z

Cucumber.js already released v3 🙈

lgandecki added 28 commits May 23, 2017 16:10

initial work to gte cucumber 2 working

d6a7231

work in progress, basic wrapping function and running cucumber progra…

0cd9ab3

…mmaticaly works

WIP, hooks working in most cases

bea0ac9

all tests passing, clean up

f414ac1

added the reporter back, working with wdio runner as a in place repla…

2dd285e

…ce for wdio-cucumber-framework

updated tests, properly deal with failures

9e089e8

updated package.json before publishing to npm

3c94793

cleanup

40f9f97

Merge pull request #1 from lgandecki/cucumber2

1d2789b

Cucumber2

prepare for npm publish

836a67a

Merge branch 'master' of https://github.com/lgandecki/wdio-cucumber2-…

e654aaf

…framework

cucumber -> cucumber2

243b12b

temporary disabled badges

01baa2b

clean up

8d7d03a

use mockery to allow people to keep cucumber imports in their spec files

a20cc64

Merge branch 'master' of https://github.com/lgandecki/wdio-cucumber2-…

b1cf73c

…framework

use custum cucumber version for now, PR to cucumber proper pending

bd3ee6e

reverting badges

600d5cc

try with circleci 2

fe299a1

Merge branch 'master' of https://github.com/lgandecki/wdio-cucumber2-…

a693880

…framework

try to use yarn instead of npm

066d6ef

switch back to circleci 1.0

7a182b7

generate coverage

72a2f5d

properly set default timeout

0da4ce8

updated so we can merge into main wdio-cucumber-framework project

c118ed1

Merge branch 'master' of https://github.com/webdriverio/wdio-cucumber…

9de298f

…-framework into cucumberv2

empty commit to rerun travis - custom cucumber version now installs yarn

6421f4a

unnecessary comment

bf4d4d6

christian-bromann reviewed May 29, 2017

View reviewed changes

simplify check for async steps

d44653e

lgandecki added 7 commits May 29, 2017 19:56

Merge branch 'cucumberv2' of https://github.com/webdriverio/wdio-cucu…

44bb22e

…mber-framework into cucumberv2

load spec files defined as both relative and absolute paths

f68e7e1

get rid of circleci config

ef863a0

update to an actuall cucumber release, with an option to pass options…

2379b24

… to the wrapper

the tagExpression should be a string now, make options default to an …

b9d00cb

…empty object

preparation for a wdio release

39aab3b

how to run with cucumber v1

ec8727f

chuan-qin reviewed Jul 12, 2017

View reviewed changes

samhatoum and others added 2 commits July 31, 2017 14:20

Disables "replacing existing mock" warning

a8e372b

Merge pull request #66 from samhatoum/patch-1

01026bf

Disables "replacing existing mock" warning

christian-bromann mentioned this pull request Aug 9, 2017

Cannot use v2 from Github #68

Closed

christian-bromann approved these changes Aug 16, 2017

View reviewed changes

christian-bromann merged commit 43743d4 into master Aug 16, 2017

christian-bromann deleted the cucumberv2 branch August 16, 2017 09:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cucumber 2 #60

Cucumber 2 #60

lgandecki commented May 29, 2017

christian-bromann left a comment

christian-bromann May 29, 2017

lgandecki May 29, 2017

christian-bromann May 29, 2017

lgandecki May 29, 2017

christian-bromann May 29, 2017

christian-bromann May 29, 2017

lgandecki May 29, 2017

christian-bromann May 29, 2017

lgandecki May 29, 2017

christian-bromann May 29, 2017

lgandecki May 29, 2017

lgandecki commented Jun 23, 2017

lgandecki commented Jun 23, 2017

chuan-qin commented Jul 12, 2017 •

edited

Loading

chuan-qin Jul 12, 2017 •

edited by christian-bromann

Loading

lgandecki Jul 13, 2017

chuan-qin Jul 13, 2017

lgandecki Jul 13, 2017

christian-bromann Aug 16, 2017

christian-bromann left a comment

christian-bromann commented Aug 16, 2017

		@@ -37,74 +41,83 @@ class CucumberAdapter {
		this.capabilities = capabilities

		this.cucumberOpts = Object.assign(DEFAULT_OPTS, config.cucumberOpts)

Cucumber 2 #60

Cucumber 2 #60

Conversation

lgandecki commented May 29, 2017

christian-bromann left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lgandecki commented Jun 23, 2017

lgandecki commented Jun 23, 2017

chuan-qin commented Jul 12, 2017 • edited Loading

chuan-qin Jul 12, 2017 • edited by christian-bromann Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

christian-bromann left a comment

Choose a reason for hiding this comment

christian-bromann commented Aug 16, 2017

chuan-qin commented Jul 12, 2017 •

edited

Loading

chuan-qin Jul 12, 2017 •

edited by christian-bromann

Loading