drivers: Document websocket-port arg, set it to random #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
christian-bromann
approved these changes
Aug 11, 2023
christian-bromann
merged commit 0abe390
into
webdriverio-community:main
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an undocumented argument (
--websocket-port) to pass togeckodriver, according to mozilla/geckodriver#2011 (comment)This change documents it and sets it to random (port zero) for new sessions.
Previously if none was set, the default (9222) would be used.
This would pose an issue when users specified
webSocketUrlcapability as N instances running in parallel would try to connect to the default port and fail.Allows for WebDriver BiDi / CDP - enabled parallel runs for Firefox with the webdriverIO project.
Fixes webdriverio/webdriverio#10839