Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installer not respecting GECKODRIVER_AUTO_INSTALL variable #356

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

BrianMwit
Copy link
Contributor

The readme states that

By default, this package downloads Geckodriver when used for the first time through the CLI or the programmatic interface. If you like to download it as part of the NPM install process, set the GECKODRIVER_AUTO_INSTALL environment flag, e.g.:

However, Boolean(process.env.GECKODRIVER_AUTO_INSTALL || '1') will always be true regardless of the GECKODRIVER_AUTO_INSTALL variable, meaning it will always download the driver during installation process.

This PR fixes the env var detection

Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👌

@christian-bromann christian-bromann merged commit 2955bc5 into webdriverio-community:main Feb 2, 2024
3 of 5 checks passed
@BrianMwit BrianMwit deleted the patch-1 branch February 8, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants